Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 290 - Add pip check #295

Merged
merged 5 commits into from
Oct 19, 2021
Merged

Issue 290 - Add pip check #295

merged 5 commits into from
Oct 19, 2021

Conversation

csala
Copy link
Contributor

@csala csala commented Oct 18, 2021

Resolve #290

Add pip check commands to the local lint command to the GitHub Actions Unit Tests workflow, to make sure that the dependency ranges are all valid for all the OSs and Python versions.

Also slightly re-organize tox and the Github workflows to follow a standard pattern of running everything with invoke.

@csala csala requested a review from a team as a code owner October 18, 2021 16:15
@csala csala requested review from pvk-developer, amontanez24 and a team and removed request for a team October 18, 2021 16:15
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good! Just had one question

pip install tox tox-gh-actions
- name: Test with tox
run: tox -e lint
python -m pip install invoke .[dev]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this one end in .[dev] when the others are pip install invoke .[test]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is installing the dev extras to include all the code style checks (flake8, isort...). The others can do with just the test dependencies, which is a smaller list.

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I only wonder why all the changes to python -m instead of just <entrypoint> command

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #295 (37c0e2f) into v0.6.0-dev (eb4f5fa) will increase coverage by 0.12%.
The diff coverage is 78.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.6.0-dev     #295      +/-   ##
==============================================
+ Coverage       81.69%   81.81%   +0.12%     
==============================================
  Files              10       11       +1     
  Lines             825      825              
==============================================
+ Hits              674      675       +1     
+ Misses            151      150       -1     
Impacted Files Coverage Δ
rdt/transformers/base.py 46.07% <47.42%> (ø)
rdt/__init__.py 34.48% <50.00%> (ø)
rdt/transformers/boolean.py 86.48% <61.53%> (ø)
rdt/transformers/datetime.py 78.78% <67.85%> (-6.07%) ⬇️
rdt/transformers/numerical.py 76.76% <69.76%> (+3.00%) ⬆️
rdt/transformers/categorical.py 91.16% <86.66%> (+0.46%) ⬆️
rdt/transformers/addons/identity/identity.py 87.50% <87.50%> (ø)
rdt/transformers/null.py 96.15% <92.30%> (ø)
rdt/transformers/__init__.py 96.55% <96.00%> (-0.17%) ⬇️
rdt/hyper_transformer.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd6c09...37c0e2f. Read the comment docs.

@csala
Copy link
Contributor Author

csala commented Oct 19, 2021

LGTM! I only wonder why all the changes to python -m instead of just <entrypoint> command

The reason was just standardization: Some workflows used python -m pip while others called pip directly, so I chose one to make it uniform. And when choosing, I opted for the python -m syntax because it is the recommended one in the packaging docs, but to be honest I think that in this case plain pip would just work too.

@csala csala merged commit 9b118c4 into v0.6.0-dev Oct 19, 2021
@csala csala deleted the issue-290-add-pip-check branch October 19, 2021 15:01
amontanez24 pushed a commit that referenced this pull request Oct 26, 2021
* Fix dependency issues

* Check dependency issues on lint

* Rename pytest task to unit

* Stop using tox on github actions

* Swtich to macos-10.15 to keep supporting Python 3.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants