-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 290 - Add pip check
#295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good! Just had one question
pip install tox tox-gh-actions | ||
- name: Test with tox | ||
run: tox -e lint | ||
python -m pip install invoke .[dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this one end in .[dev]
when the others are pip install invoke .[test]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is installing the dev
extras to include all the code style checks (flake8
, isort
...). The others can do with just the test
dependencies, which is a smaller list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I only wonder why all the changes to python -m
instead of just <entrypoint> command
e8563b3
to
37c0e2f
Compare
Codecov Report
@@ Coverage Diff @@
## v0.6.0-dev #295 +/- ##
==============================================
+ Coverage 81.69% 81.81% +0.12%
==============================================
Files 10 11 +1
Lines 825 825
==============================================
+ Hits 674 675 +1
+ Misses 151 150 -1
Continue to review full report at Codecov.
|
The reason was just standardization: Some workflows used |
Resolve #290
Add
pip check
commands to the locallint
command to the GitHub ActionsUnit Tests
workflow, to make sure that the dependency ranges are all valid for all the OSs and Python versions.Also slightly re-organize
tox
and the Github workflows to follow a standard pattern of running everything withinvoke
.