Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip check to CI workflows #290

Closed
csala opened this issue Oct 13, 2021 · 0 comments
Closed

Add pip check to CI workflows #290

csala opened this issue Oct 13, 2021 · 0 comments
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@csala
Copy link
Contributor

csala commented Oct 13, 2021

The current CI workflows and local test and lint commands do not catch dependency incompatibilities.

For example, installing the repository for development on the v0.6.0-dev branch results in these errors:

ERROR: flake8 3.9.2 has requirement pycodestyle<2.8.0,>=2.7.0, but you'll have pycodestyle 2.8.0 which is incompatible.
ERROR: flake8 3.9.2 has requirement pyflakes<2.4.0,>=2.3.0, but you'll have pyflakes 2.4.0 which is incompatible.

A pip check command should be made part of the local and CI tests to make sure that our dependency tree is always clean.

@amontanez24 amontanez24 added internal The issue doesn't change the API or functionality and removed internal The issue doesn't change the API or functionality labels Oct 26, 2021
@amontanez24 amontanez24 added this to the 0.6.0 milestone Oct 26, 2021
@pvk-developer pvk-developer added the internal The issue doesn't change the API or functionality label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

No branches or pull requests

3 participants