Skip to content

new files for ipl3 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged

new files for ipl3 #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions data/ipl3.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ astraAllStarAstroNN = $MWM_ASTRA/{v_astra}/summary/astraAllStarAstroNN-{v_astra}
astraAllVisitAstroNN = $MWM_ASTRA/{v_astra}/summary/astraAllVisitAstroNN-{v_astra}.fits
astraAllStarApogeeNet = $MWM_ASTRA/{v_astra}/summary/astraAllStarApogeeNet-{v_astra}.fits
astraAllVisitApogeeNet = $MWM_ASTRA/{v_astra}/summary/astraAllVisitApogeeNet-{v_astra}.fits
astraAllStarApogeeNetv2 = $MWM_ASTRA/{v_astra}/summary/astraAllStarApogeeNetv2-{v_astra}.fits
astraAllVisitApogeeNetv2 = $MWM_ASTRA/{v_astra}/summary/astraAllVisitApogeeNetv2-{v_astra}.fits
astraAllStarBossNet = $MWM_ASTRA/{v_astra}/summary/astraAllStarBossNet-{v_astra}.fits
astraAllVisitBossNet = $MWM_ASTRA/{v_astra}/summary/astraAllVisitBossNet-{v_astra}.fits
Comment on lines +200 to +203
Copy link
Collaborator

@havok2063 havok2063 Nov 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you have a lot of related file species that only vary by a name, I would suggest we consolidate all these paths down by adding more template keywords. Something like

astraAllStar = $MWM_ASTRA/{v_astra}/summary/astraAllStar{pipeline}-{v_astra}.fits
astraAllVisit = $MWM_ASTRA/{v_astra}/summary/astraAllVisit{pipeline}-{v_astra}.fits

to replace all the separate allStar and allVisit files. These are really all one type of data product anyway. I think this can also be done with the astra pipeline output paths, e.g.

astraStar = $MWM_ASTRA/{v_astra}/results/star/@sdss_id_groups|/astraStar{pipeline}-{v_astra}-{sdss_id}@component_default|.fits
astraVisit = $MWM_ASTRA/{v_astra}/results/visit/@sdss_id_groups|/astraVisit{pipeline}-{v_astra}-{sdss_id}@component_default|.fits

This means you can also flexibly add pipelines or change pipeline names and we don't need to always update the tree.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Brian, these are only superficially the "same" species but each has a different data model! They are different species with different datamodels, so collectivizing their paths would not be helpful for the data products database.

astraAllStarClassifier = $MWM_ASTRA/{v_astra}/summary/astraAllStarClassifier-{v_astra}.fits
astraAllVisitClassifier = $MWM_ASTRA/{v_astra}/summary/astraAllVisitClassifier-{v_astra}.fits
astraAllStarTheCannon = $MWM_ASTRA/{v_astra}/summary/astraAllStarTheCannon-{v_astra}.fits
Expand All @@ -209,6 +213,7 @@ astraAllStarMDwarfType = $MWM_ASTRA/{v_astra}/summary/astraAllStarMDwarfType-{v_
astraAllVisitMDwarfType = $MWM_ASTRA/{v_astra}/summary/astraAllVisitMDwarfType-{v_astra}.fits
astraAllStarThePayne = $MWM_ASTRA/{v_astra}/summary/astraAllStarThePayne-{v_astra}.fits
astraAllVisitThePayne = $MWM_ASTRA/{v_astra}/summary/astraAllVisitThePayne-{v_astra}.fits
astraAllVisitHotPayne = $MWM_ASTRA/{v_astra}/summary/astraAllVisitHotPayne-{v_astra}.fits
astraAllStarSLAM = $MWM_ASTRA/{v_astra}/summary/astraAllStarSLAM-{v_astra}.fits
astraAllVisitSLAM = $MWM_ASTRA/{v_astra}/summary/astraAllVisitSLAM-{v_astra}.fits
astraAllStarSnowWhite = $MWM_ASTRA/{v_astra}/summary/astraAllStarSnowWhite-{v_astra}.fits
Expand Down
5 changes: 5 additions & 0 deletions data/sdsswork.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,10 @@ astraAllStarAstroNN = $MWM_ASTRA/{v_astra}/summary/astraAllStarAstroNN-{v_astra}
astraAllVisitAstroNN = $MWM_ASTRA/{v_astra}/summary/astraAllVisitAstroNN-{v_astra}.fits
astraAllStarApogeeNet = $MWM_ASTRA/{v_astra}/summary/astraAllStarApogeeNet-{v_astra}.fits
astraAllVisitApogeeNet = $MWM_ASTRA/{v_astra}/summary/astraAllVisitApogeeNet-{v_astra}.fits
astraAllStarApogeeNetv2 = $MWM_ASTRA/{v_astra}/summary/astraAllStarApogeeNetv2-{v_astra}.fits
astraAllVisitApogeeNetv2 = $MWM_ASTRA/{v_astra}/summary/astraAllVisitApogeeNetv2-{v_astra}.fits
astraAllStarBossNet = $MWM_ASTRA/{v_astra}/summary/astraAllStarBossNet-{v_astra}.fits
astraAllVisitBossNet = $MWM_ASTRA/{v_astra}/summary/astraAllVisitBossNet-{v_astra}.fits
astraAllStarClassifier = $MWM_ASTRA/{v_astra}/summary/astraAllStarClassifier-{v_astra}.fits
astraAllVisitClassifier = $MWM_ASTRA/{v_astra}/summary/astraAllVisitClassifier-{v_astra}.fits
astraAllStarTheCannon = $MWM_ASTRA/{v_astra}/summary/astraAllStarTheCannon-{v_astra}.fits
Expand All @@ -382,6 +386,7 @@ astraAllStarMDwarfType = $MWM_ASTRA/{v_astra}/summary/astraAllStarMDwarfType-{v_
astraAllVisitMDwarfType = $MWM_ASTRA/{v_astra}/summary/astraAllVisitMDwarfType-{v_astra}.fits
astraAllStarThePayne = $MWM_ASTRA/{v_astra}/summary/astraAllStarThePayne-{v_astra}.fits
astraAllVisitThePayne = $MWM_ASTRA/{v_astra}/summary/astraAllVisitThePayne-{v_astra}.fits
astraAllVisitHotPayne = $MWM_ASTRA/{v_astra}/summary/astraAllVisitHotPayne-{v_astra}.fits
astraAllStarSLAM = $MWM_ASTRA/{v_astra}/summary/astraAllStarSLAM-{v_astra}.fits
astraAllVisitSLAM = $MWM_ASTRA/{v_astra}/summary/astraAllVisitSLAM-{v_astra}.fits
astraAllStarSnowWhite = $MWM_ASTRA/{v_astra}/summary/astraAllStarSnowWhite-{v_astra}.fits
Expand Down