new files for ipl3 #73
Conversation
| astraAllStarApogeeNetv2 = $MWM_ASTRA/{v_astra}/summary/astraAllStarApogeeNetv2-{v_astra}.fits | ||
| astraAllVisitApogeeNetv2 = $MWM_ASTRA/{v_astra}/summary/astraAllVisitApogeeNetv2-{v_astra}.fits | ||
| astraAllStarBossNet = $MWM_ASTRA/{v_astra}/summary/astraAllStarBossNet-{v_astra}.fits | ||
| astraAllVisitBossNet = $MWM_ASTRA/{v_astra}/summary/astraAllVisitBossNet-{v_astra}.fits |
There was a problem hiding this comment.
Given that you have a lot of related file species that only vary by a name, I would suggest we consolidate all these paths down by adding more template keywords. Something like
astraAllStar = $MWM_ASTRA/{v_astra}/summary/astraAllStar{pipeline}-{v_astra}.fits
astraAllVisit = $MWM_ASTRA/{v_astra}/summary/astraAllVisit{pipeline}-{v_astra}.fits
to replace all the separate allStar and allVisit files. These are really all one type of data product anyway. I think this can also be done with the astra pipeline output paths, e.g.
astraStar = $MWM_ASTRA/{v_astra}/results/star/@sdss_id_groups|/astraStar{pipeline}-{v_astra}-{sdss_id}@component_default|.fits
astraVisit = $MWM_ASTRA/{v_astra}/results/visit/@sdss_id_groups|/astraVisit{pipeline}-{v_astra}-{sdss_id}@component_default|.fits
This means you can also flexibly add pipelines or change pipeline names and we don't need to always update the tree.
There was a problem hiding this comment.
No Brian, these are only superficially the "same" species but each has a different data model! They are different species with different datamodels, so collectivizing their paths would not be helpful for the data products database.
|
@ajwheeler pinging you manually since this was already merged, and I'd like discuss my comment. |
No description provided.