Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

A bit of cleaning up the tests #212

Merged
merged 2 commits into from
Apr 9, 2017
Merged

A bit of cleaning up the tests #212

merged 2 commits into from
Apr 9, 2017

Commits on Apr 8, 2017

  1. Always remove temp dir after test in vcs_source_test 

    Some tests in vcs_source_test did not always delete the temp dir they
created. The git-source tests for example only removed the temp dirs for
certain failure conditions, but not when the test passed. This is fixed
by deferring the cleanup function right after creating the temp dirs for
each test.
    @jstemmer
    jstemmer committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    b3b498e View commit details
    Browse the repository at this point in the history

  2. Replace Errorf followed by FailNow with Fatalf 

    When running tests, calling t.Errorf followed by a t.FailNow is pretty
much the same as just calling t.Fatalf. I've also change a couple of
cute error messages.
    @jstemmer
    jstemmer committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    920fde1 View commit details
    Browse the repository at this point in the history