This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
A bit of cleaning up the tests #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests in vcs_source_test did not always delete the temp dir they created. The git-source tests for example only removed the temp dirs for certain failure conditions, but not when the test passed. This is fixed by deferring the cleanup function right after creating the temp dirs for each test.
When running tests, calling t.Errorf followed by a t.FailNow is pretty much the same as just calling t.Fatalf. I've also change a couple of cute error messages.
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=========================================
+ Coverage 78.03% 78.3% +0.27%
=========================================
Files 28 28
Lines 4020 4020
=========================================
+ Hits 3137 3148 +11
+ Misses 658 650 -8
+ Partials 225 222 -3
Continue to review full report at Codecov.
|
|
Thanks! And, weird...looking at |
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
A bit of cleaning up the tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on getting Fastwalk (#180) to work correctly (which btw also needs some changes that I'm planning to submit upstream soon), I noticed a bunch of temp dirs were left behind after running all the tests. And while dealing with that I also found some instances of
t.Errorffollowed byt.FailNowin the tests that could be replaced with a single call tot.Fatalf.