Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair refactor #3521

Merged
merged 10 commits into from
Aug 14, 2023
Merged

Repair refactor #3521

merged 10 commits into from
Aug 14, 2023

Conversation

Michal-Leszczynski
Copy link
Collaborator

@Michal-Leszczynski Michal-Leszczynski commented Aug 11, 2023 •
edited by karol-kokoszka
Loading

Dtests: https://jenkins.scylladb.com/job/manager-master/job/manager-dtest/1288/

  • failing manager_restore_tests.TestScyllaMgmtRestore.test_restore_schema_with_mv (recent changes on master - full restore automation) - no regression

Ubuntu22 Sanity-tests: https://jenkins.scylladb.com/job/manager-master/job/ubuntu22-sanity-test/294/

Centos Sanity-tests: https://jenkins.scylladb.com/job/manager-master/job/centos-sanity-test/1000/

Fixes #3463
Fixes #3426
Fixes #3425
Fixes #3424
Fixes #3423
Fixes #3367
Fixes #3362
Fixes #3191
Fixes #3522

This was referenced Aug 12, 2023
Closed
Closed
@karol-kokoszka karol-kokoszka force-pushed the ml/repair_refactor branch 3 times, most recently from 05fab66 to f6d01eb Compare August 14, 2023 08:06
@karol-kokoszka karol-kokoszka marked this pull request as ready for review August 14, 2023 08:13
Michal-Leszczynski and others added 5 commits August 14, 2023 11:08
@Michal-Leszczynski @karol-kokoszka
fix(repair): make repair follow docs
d35a8d3 
Repair table by table while ensuring that there is only one repair job per host at any time.
Moreover, drop support for polling, long polling and legacy repair.

Fixes #3425
Fixes #3463
Fixes #3515
@Michal-Leszczynski @karol-kokoszka
feat(repair): sort repair plan
69676fc 
Fixes #3362
Fixes #3367
@Michal-Leszczynski @karol-kokoszka
feat(repair): choose repair master by smallest shard cnt
421f7a1 
Fixes #3426
@Michal-Leszczynski @karol-kokoszka
feat(repair): deprecate (0,1) intensity
f5ba79b 
Fixes #3424
@karol-kokoszka
feat(repair): additional integration-tests
6c0f21d 
This PR adds tests ensuring that:
 - single table is repaired at a time
 - the MV is repaired after the base table
 - the repaired order is preserved
 - controller respects parallel and intensity values
karol-kokoszka
karol-kokoszka approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@karol-kokoszka karol-kokoszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@karol-kokoszka karol-kokoszka merged commit 7033b3d into master Aug 14, 2023
62 checks passed
@karol-kokoszka karol-kokoszka deleted the ml/repair_refactor branch August 14, 2023 09:58
@vladzcloudius
Copy link
Contributor

@mykaul did you review this?
Could you tell us how well was it tested?

@vladzcloudius
Copy link
Contributor

vladzcloudius commented Aug 15, 2023 •
edited
Loading

cc @tomer-sandler @harel-z @ruthea

@vladzcloudius
Copy link
Contributor

@mykaul could you tell us what's the status of fixing issues "fixed" by this PR in the short term?

@vladzcloudius
Copy link
Contributor

FYI @asias

@mykaul
Copy link
Contributor

mykaul commented Aug 16, 2023

@mykaul could you tell us what's the status of fixing issues "fixed" by this PR in the short term?

I did not fully understand the question... I'm not sure what "fixed" means and what short term refers to.

@vladzcloudius
Copy link
Contributor

@mykaul could you tell us what's the status of fixing issues "fixed" by this PR in the short term?

I did not fully understand the question... I'm not sure what "fixed" means

I was referring the "Fixed #..." statements in corresponding patches.
Like here:

image

and what short term refers to.

Short term was referring the time frame of the previous week.
But I think we all know the answer by now (SM 3.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karol-kokoszka karol-kokoszka karol-kokoszka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Michal-Leszczynski @vladzcloudius @mykaul @karol-kokoszka