repair: ensure max single repair job per host #3518
Conversation
| @@ -74,7 +74,7 @@ func (c *rowLevelRepairController) shouldBlock(hosts []string, intensity int) bo | |||
|
|
|||
| // DENY if any host has max nr of jobs already running | |||
| for _, h := range hosts { | |||
| if c.jobs[h] >= c.limits[h].Default { | |||
| if c.jobs[h] >= 1 { | |||
There was a problem hiding this comment.
nit: the comment in line 75 is now inaccurate.
There was a problem hiding this comment.
thanks, updated the comment + removed another checks that are not relevant anymore
karol-kokoszka
force-pushed
the
ensure_only_one_repair_job_per_host
branch
from
b91d28f
to
6eb2729
Compare
| @@ -199,44 +155,3 @@ func TestRowLevelRepairController(t *testing.T) { | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| func TestRowLevelRepairControllerIssue2446(t *testing.T) { | |||
There was a problem hiding this comment.
Why this test was removed?
| t.Fatal("TryBlock() failed to block") | ||
| } | ||
| if a.Ranges != intensity { |
There was a problem hiding this comment.
Should be ">" - exactly as the error message below states.
Repair task is allowed to pick less than "intensity" ranges, e.g. in the last hunk.
|
There is already a PR that fixes this and other issues which was submitted some time ago: #3506 This PR pretty much copies what this patch (8020beb) from the PR above does in terms of SM fix. Don't you think that it makes more sense to pick the code part from the PR above and leave only the test part from this PR? |
|
Closing as #3521 is ready |
Fixes #3425
"Only the Best is Good Enough." - LEGO company motto
Please make sure that: