Paragraph: Add text column support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the textColumns support flag to the paragraph block's block.json file to enable CSS columns support. This completes the backport alongside the PHP changes already committed. Props: scruffian See: WordPress/gutenberg#74656 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
When no attributes are present, `wp_kses_hair()` should return an empty array, but when the refactor was merged, the code assumed there would be attributes. An alternative fix is to use null-coalescing to iterate over an empty array. This would produce a marginally smaller function and read slightly more cleanly, but there’s no need to enter the `foreach` loop when it’s known in advance that there’s nothing over which to iterate. Developed in: WordPress#10758 Discussed in: https://core.trac.wordpress.org/ticket/63724 Follow-up to [61467]. Props: dd32, dmsnell, jonsurrell. See: #63724. git-svn-id: https://develop.svn.wordpress.org/trunk@61499 602fd350-edb4-49c9-b593-d223f7449a82
…ources. Follow-up to [49478], [49574]. Props sabernhardt. Fixes #64526. git-svn-id: https://develop.svn.wordpress.org/trunk@61500 602fd350-edb4-49c9-b593-d223f7449a82
…n `wp_image_add_srcset_and_sizes()`. Follow-up to [35412]. Props debarghyabanerjee, sabernhardt, shanemac10, leedxw, MadtownLems, enravo, djsuperfive, westonruter. See #34430. Fixes #60480. git-svn-id: https://develop.svn.wordpress.org/trunk@61501 602fd350-edb4-49c9-b593-d223f7449a82
…n is not preferred. Developed in WordPress#10762 Follow-up to [61491]. Props mukesh27, wildworks, solankisoftware, westonruter. See #64470. Fixes #64529. git-svn-id: https://develop.svn.wordpress.org/trunk@61502 602fd350-edb4-49c9-b593-d223f7449a82
When `wp_kses_hair()` calls into the HTML API to parse an attribute string, it checks if the result might be `null` and returns early, skipping a few minor operations. It could also skip when the returned attribute count is zero. This patch adds the additional check and early-return. Developed in: WordPress#10764 Discussed in: https://core.trac.wordpress.org/ticket/63724 Follow-up to [61499]. Props dd32, dmsnell, jonsurrell. See #63724. git-svn-id: https://develop.svn.wordpress.org/trunk@61503 602fd350-edb4-49c9-b593-d223f7449a82
The work in [61438] for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in [61492] which left WordPress in an inoperable state. This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch). Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core. Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over. Developed in: WordPress#10761 Discussed in: https://core.trac.wordpress.org/ticket/64521 Follow-up to [61438], [61492]. Props dmsnell, mcsf, mukesh27, youknowriad. Fixes #64521. git-svn-id: https://develop.svn.wordpress.org/trunk@61504 602fd350-edb4-49c9-b593-d223f7449a82
The parameter name is optional in PHPStan but not supported by Psalm. While neither tools are officially supported, this removes the parse error that Psalm users otherwise see. See php-stubs/wordpress-stubs#410 for some external discussion. Props farhad0, marian1 See #64224 git-svn-id: https://develop.svn.wordpress.org/trunk@61505 602fd350-edb4-49c9-b593-d223f7449a82
- Replace `https.request()` with native `fetch()` in `log-results.js`. - Drop www. from host name used to avoid redirects. Props mcsf. Fixes #64534. git-svn-id: https://develop.svn.wordpress.org/trunk@61507 602fd350-edb4-49c9-b593-d223f7449a82
…e()`. Follow-up to [10204], [32652]. Props rejaulalomkhan, huzaifaalmesbah. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61508 602fd350-edb4-49c9-b593-d223f7449a82
The behavior of WP_Block_Processor::extract_full_block_and_advance() should produce an identical output to what parse_blocks() would return on the same substring of input. Unfortunately, when HTML spans followed inner blocks, they were being omitted in the output parse tree. This was due to an omission in the original code which would look for those blocks before advancing again after calling `extract_full_block_and_advance()` recursively. This patch adds the missing check and resolves the discrepancy. Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64538 Follow-up to [60939]. Props dmsnell, jonsurrell, jorbin. Fixes #64537. git-svn-id: https://develop.svn.wordpress.org/trunk@61509 602fd350-edb4-49c9-b593-d223f7449a82
Changes the color on items added to menus in the Customizer from `#8c8f94` (a contrast ratio of 3.24:1) to `#646970` (a contrast ratio of 5.53:1). Props joedolson, sabernhardt, wilcosky, showravhasan, emptyopssphere, ozgursar. Fixes #64013. git-svn-id: https://develop.svn.wordpress.org/trunk@61511 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [14760]. Props rejaulalomkhan, huzaifaalmesbah, westonruter, SergeyBiryukov. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61512 602fd350-edb4-49c9-b593-d223f7449a82
Adds styles for responsive grid layouts and fixes a block gap bug and a max column width bug. Props isabel_brison, aaronrobertshaw. Fixes #64532. git-svn-id: https://develop.svn.wordpress.org/trunk@61513 602fd350-edb4-49c9-b593-d223f7449a82
Webkit-based browsers add a cancel button to search inputs. This input uses the default cursor standard to buttons and inputs, but the WordPress admin applies the `pointer` cursor to buttons and inputs. Apply the WordPress standard pointer to this pseudoelement for UI consistency. Props sumitsingh, manhphucofficial, joedolson, sabernhardt, dhruvang21. Fixes #64382. git-svn-id: https://develop.svn.wordpress.org/trunk@61514 602fd350-edb4-49c9-b593-d223f7449a82
Remove the autofocus script in Twenty Ten that forced a bypass of the navigation, main heading, and explanation on the 404 error page. Props sabernhardt, ravichudasama01, joedolson. Fixes #64064. git-svn-id: https://develop.svn.wordpress.org/trunk@61515 602fd350-edb4-49c9-b593-d223f7449a82
Checks that the value passed to add_declaration is a string to prevent fatal errors due to malformed block attributes. Props andrewserong. Fixes #64545. git-svn-id: https://develop.svn.wordpress.org/trunk@61516 602fd350-edb4-49c9-b593-d223f7449a82
… variables. Introduce the `wp-base-styles` stylesheet handle to provide admin color scheme CSS custom properties across WordPress. This stylesheet is added as a dependency for: - The `wp-admin` styles bundle - The block editor content iframe styles This is the Core-side implementation of the changes from Gutenberg PRs #69128 and #69130, which consolidate the admin color scheme CSS custom properties into a single reusable stylesheet instead of duplicating them across multiple packages. See #64308. Props fabiankaegy, wildworks. git-svn-id: https://develop.svn.wordpress.org/trunk@61517 602fd350-edb4-49c9-b593-d223f7449a82
The function is no longer used by WordPress and better alternatives are available: `wp_get_script_tag()` and `wp_get_inline_script_tag()`. Developed in WordPress#10742. Follow-up to [61415], [61485]. Props jonsurrell, westonruter. Fixes #64511. See #64442. git-svn-id: https://develop.svn.wordpress.org/trunk@61518 602fd350-edb4-49c9-b593-d223f7449a82
Ensure whitespace text nodes are correctly represented by `build_visual_html_tree()`. The `build_visual_html_tree()` function used by `assertEqualHTML()` would remove some leading whitespace from text nodes. Some whitespace-only text nodes were omitted from the tree. Developed in WordPress#10765. Follow-up to [60295]. Props jonsurrell, dmsnell, bernhard-reiter. Fixes #64531. git-svn-id: https://develop.svn.wordpress.org/trunk@61519 602fd350-edb4-49c9-b593-d223f7449a82
…ore_upgrade()`. Developed in WordPress#10570 Follow-up to [61512], [32642], [32654]. Props rejaulalomkhan, westonruter, huzaifaalmesbah. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61520 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress#10569 Follow-up to [32642]. Props huzaifaalmesbah, westonruter, noruzzaman. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61521 602fd350-edb4-49c9-b593-d223f7449a82
…_response()`. Follow-up to [61508]. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61522 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [14760]. Props huzaifaalmesbah. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61523 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [31146], [35021]. Props huzaifaalmesbah. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61524 602fd350-edb4-49c9-b593-d223f7449a82
Fix an issue where adding `comment_type=all` as a query parameter to the `wp-admin/edit-comments.php` page would unexpectedly cause notes to show. Follow-up to [61183]. Props adamsilverstein, jorbin, mukesh27, ozgursar, Presskopp, r1k0, rollybueno, soyebsalar01, westonruter, wildworks. Fixes #64474. git-svn-id: https://develop.svn.wordpress.org/trunk@61525 602fd350-edb4-49c9-b593-d223f7449a82
Support for non-HTML5 scripts was removed in [61415]. Removes obsolete tests and references to the non-HTML5 script behaviors including CDATA wrappers and `type` attributes. Developed in WordPress#10740. Follow-up to [61415]. Props jonsurrell, westonruter, mukesh27. Fixes #64442. git-svn-id: https://develop.svn.wordpress.org/trunk@61526 602fd350-edb4-49c9-b593-d223f7449a82
Update custom CSS validation to allow any CSS except `STYLE` close tags. Previously, some valid CSS would be rejected for containing HTML syntax characters, like this example:
{{{
@Property --animate {
syntax: "<custom-ident>"; /* <-- Validation error on `<` */
inherits: true;
initial-value: false;
}
}}}
Developed in WordPress#10667.
Follow-up to [61418], [61486].
Props jonsurrell, westonruter, peterwilsoncc, johnbillion, xknown, sabernhardt, dmsnell, soyebsalar01, dlh.
Fixes #64418.
git-svn-id: https://develop.svn.wordpress.org/trunk@61527 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [7043], [7092], [8304], [9053], [21871]. Props huzaifaalmesbah. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61532 602fd350-edb4-49c9-b593-d223f7449a82
Remove the text color setting on the Written by pattern. The setting was resulting in color contrast that was well below contrast guidelines. Allow the text color to be inherited by default. Props poena, rinkalpagdar, narenin, sabernhardt, noruzzaman, huzaifaalmesbah, joedolson. Fixes #62982. git-svn-id: https://develop.svn.wordpress.org/trunk@61534 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport of Gutenberg PR #74656 to enable CSS columns support for the paragraph block.
Changes:
textColumnsto theAPPEARANCE_TOOLS_OPT_INSconstant inWP_Theme_JSONtextColumns: truesupport flagtextColumnsin expected appearance tools outputThis allows users to control the number of columns in paragraph typography settings through both the editor and frontend, providing a simple multi-column layout option without requiring additional container blocks.
Test plan
Related
Props: @scruffian
🤖 Generated with Claude Code