-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Paragraph: Add text column support #74656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Flaky tests detected in e8a817b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21034285705
|
mikachan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, but it looks like the test failure is a genuine related failure, and I think we'll need a backport PR for the changes in lib/class-wp-theme-json-gutenberg.php.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tellthemachines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Overall, it looks good to me, but I have left some feedback.
| 'lineHeight' => null, | ||
| 'textAlign' => null, | ||
| 'textColumns' => null, | ||
| 'textColumns' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep this code as is 😅 ('textColumns' => null), otherwise the textColumns setting will be considered invalid, and the UI will not be able to disable it.
Without this code, we can't disable the UI using a theme.json like this:
{
"version": 3,
"settings": {
"appearanceTools": true,
"layout": {
"contentSize": "840px",
"wideSize": "1100px"
},
"typography": {
"textColumns": false
}
}
}Adds the textColumns support flag to the paragraph block's block.json file to enable CSS columns support. This completes the backport alongside the PHP changes already committed. Props: scruffian See: WordPress/gutenberg#74656 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Links to Core PR that backports the textColumns test fix. Backport of WordPress/wordpress-develop#10756 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* Paragraph: Add text column support * linter fix * remove unneeded change * Add backport changelog for textColumns in appearanceTools Links to Core PR that backports the textColumns test fix. Backport of WordPress/wordpress-develop#10756 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * update changelog backports --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This changeset adds `textColumn` block support to appearance tools opt-ins. Backports Gutenberg PR 74656: WordPress/gutenberg#74656 Props scruffian, wildworks. Fixes #64530 git-svn-id: https://develop.svn.wordpress.org/trunk@61570 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adds `textColumn` block support to appearance tools opt-ins. Backports Gutenberg PR 74656: WordPress/gutenberg#74656 Props scruffian, wildworks. Fixes #64530 Built from https://develop.svn.wordpress.org/trunk@61570 git-svn-id: http://core.svn.wordpress.org/trunk@60881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset adds `textColumn` block support to appearance tools opt-ins. Backports Gutenberg PR 74656: WordPress/gutenberg#74656 Props scruffian, wildworks. Fixes #64530 git-svn-id: https://develop.svn.wordpress.org/trunk@61570 602fd350-edb4-49c9-b593-d223f7449a82
|
Just added the label Needs Dev Note as the theme.json updates would help theme developer to get a hang of the new feature. It could be part of a possible roundup post of theme.json updates. |

What?
Closes #27118
Enables columns support in a paragraph block
Why?
This is a useful control for the paragraph block.
How?
Add support for
textColumnsto the blockTesting Instructions
Screenshots or screencast