Skip to content

Conversation

@scruffian
Copy link
Contributor

@scruffian scruffian commented Jan 15, 2026

What?

Closes #27118

Enables columns support in a paragraph block

Why?

This is a useful control for the paragraph block.

How?

Add support for textColumns to the block

Testing Instructions

  1. Select a paragraph block
  2. Enable columns in the paragraph typography block
  3. Confirm that changes to the number of columns are reflected in the frontend and editor

Screenshots or screencast

Screenshot 2026-01-15 at 14 11 01

@scruffian scruffian self-assigned this Jan 15, 2026
@scruffian scruffian added the [Block] Paragraph Affects the Paragraph Block label Jan 15, 2026
@github-actions github-actions bot added the [Package] Block library /packages/block-library label Jan 15, 2026
@mikachan mikachan added the [Type] Enhancement A suggestion for improvement. label Jan 15, 2026
@github-actions
Copy link

Flaky tests detected in e8a817b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21034285705
📝 Reported issues:

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but it looks like the test failure is a genuine related failure, and I think we'll need a backport PR for the changes in lib/class-wp-theme-json-gutenberg.php.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: aristath <aristath@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: kjellr <kjellr@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works really well with the recently added wide/full alignment!

Image

The theme json class changes will need a trac ticket + wp-develop PR and then adding PR link to backport changelog, which should make the CI check pass.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall, it looks good to me, but I have left some feedback.

'lineHeight' => null,
'textAlign' => null,
'textColumns' => null,
'textColumns' => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this change? Is this related to the type markers introduced in #73452? I guess it will work fine even if left null.

cc @ramonjd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep this code as is 😅 ('textColumns' => null), otherwise the textColumns setting will be considered invalid, and the UI will not be able to disable it.

Without this code, we can't disable the UI using a theme.json like this:

{
	"version": 3,
	"settings": {
		"appearanceTools": true,
		"layout": {
			"contentSize": "840px",
			"wideSize": "1100px"
		},
		"typography": {
			"textColumns": false
		}
	}
}

scruffian added a commit to scruffian/wordpress-develop that referenced this pull request Jan 19, 2026
Adds the textColumns support flag to the paragraph block's block.json file to enable CSS columns support. This completes the backport alongside the PHP changes already committed.

Props: scruffian
See: WordPress/gutenberg#74656

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
scruffian and others added 2 commits January 19, 2026 12:40
Links to Core PR that backports the textColumns test fix.

Backport of WordPress/wordpress-develop#10756

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@scruffian scruffian merged commit 6cad1b9 into trunk Jan 20, 2026
42 of 43 checks passed
@scruffian scruffian deleted the add/paragraph-columns branch January 20, 2026 08:11
@github-actions github-actions bot added this to the Gutenberg 22.5 milestone Jan 20, 2026
adamsilverstein pushed a commit that referenced this pull request Jan 20, 2026
* Paragraph: Add text column support

* linter fix

* remove unneeded change

* Add backport changelog for textColumns in appearanceTools

Links to Core PR that backports the textColumns test fix.

Backport of WordPress/wordpress-develop#10756

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* update changelog backports

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Feb 1, 2026
This changeset adds `textColumn` block support to appearance tools opt-ins.
Backports Gutenberg PR 74656: WordPress/gutenberg#74656

Props scruffian, wildworks.
Fixes #64530


git-svn-id: https://develop.svn.wordpress.org/trunk@61570 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 1, 2026
This changeset adds `textColumn` block support to appearance tools opt-ins.
Backports Gutenberg PR 74656: WordPress/gutenberg#74656

Props scruffian, wildworks.
Fixes #64530

Built from https://develop.svn.wordpress.org/trunk@61570


git-svn-id: http://core.svn.wordpress.org/trunk@60881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
whaze pushed a commit to whaze/wordpress-develop that referenced this pull request Feb 3, 2026
This changeset adds `textColumn` block support to appearance tools opt-ins.
Backports Gutenberg PR 74656: WordPress/gutenberg#74656

Props scruffian, wildworks.
Fixes #64530


git-svn-id: https://develop.svn.wordpress.org/trunk@61570 602fd350-edb4-49c9-b593-d223f7449a82
@bph bph added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Feb 3, 2026
@bph
Copy link
Contributor

bph commented Feb 3, 2026

Just added the label Needs Dev Note as the theme.json updates would help theme developer to get a hang of the new feature. It could be part of a possible roundup post of theme.json updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Paragraph Affects the Paragraph Block Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paragraph: Add CSS columns

6 participants