This repository was archived by the owner on Apr 18, 2025. It is now read-only.
ec_sub_unequal would have panicked for some edge cases
#999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roynalnaruto
changed the title
ec_sub_unequal would have panicked for some edge cases
zhenfeizhang
approved these changes
Oct 11, 2023
zhenfeizhang
left a comment
zhenfeizhang
left a comment
There was a problem hiding this comment.
LGTM. Thanks for handling this...
lispc
pushed a commit
that referenced
this pull request
Oct 25, 2023
* fix soundness bug in ecdsa circuit * update parameters * fix: ec_sub_unequal would have panicked for some edge cases (#999) * update ecdsa parameters --------- Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ECDSA function would have panicked for edge cases. This PR implements the
ec_add_unequalforu1_mul + u2_mulin a non-panicking way, and handles cases such asu1_is_zeroandu2_is_zeroby theSelectabletrait.Instead of using the random point approach, we compute
u1_mul + u2_multaking into account edge cases such as:We effectively do not need the random point (tmp) approach, and have the EC Point
sum, i.e.(x_3, y_3)by making minor changes to thedivide_unsafelogic and usingSelectabletrait to select appropriate values forx_3andy_3.