Fix/tob wave3 ecdsa circuit review

[zhenfeizhang]

Description

[PR description]

Issue Link

[link issue here]

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Contents

• [item]

Rationale

In ecdsa circuit, it requires u1G + u2PK != infinity. The code handles this condition incorrectly. This PR fixes the issue.

CAVEAT: this fix uses run time random point to handle point at infinity, similar to the tricks in scalar_multiply. Ideally we want to avoid this hack.

How Has This Been Tested?

[explanation]

---

How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

• What types of design choices did you face?
• What decisions you have made?
• Any valuable information that could help reviewers to think critically

[roynalnaruto]

Some minor points, let me know your opinion

[lispc]

@zhenfeizhang seems the cell num usage constant is not updated to last commit?

[zhenfeizhang]

@zhenfeizhang seems the cell num usage constant is not updated to last commit?

yes. fixed now