Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

feat(1559): constrain tx gas price == effective gas price #1152

Merged
merged 17 commits into from
Apr 22, 2024

Conversation

DreamWuGit
Copy link

@DreamWuGit DreamWuGit commented Mar 18, 2024

Description

constrain tx gas price == effective gas tip for EIP 1559, new fields need more cells so increase step_width as well

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@DreamWuGit DreamWuGit marked this pull request as ready for review March 19, 2024 03:26
@DreamWuGit DreamWuGit mentioned this pull request Mar 19, 2024
8 tasks
@lispc
Copy link

lispc commented Apr 22, 2024

Add comment somewhere, explain tx_gas_price is looked up from TxTable in zkevm-circuits/src/evm_circuit/execution/begin_tx.rs

@DreamWuGit
Copy link
Author

Add comment somewhere, explain tx_gas_price is looked up from TxTable in zkevm-circuits/src/evm_circuit/execution/begin_tx.rs

added in this commit e1a0d3b

@lispc lispc changed the title constrain tx gas price == effective gas tip feat(1559): constrain tx gas price == effective gas tip Apr 22, 2024
@lispc lispc changed the title feat(1559): constrain tx gas price == effective gas tip feat(1559): constrain tx gas price == effective gas price Apr 22, 2024
@lispc lispc merged commit b1bb7c7 into develop Apr 22, 2024
@lispc lispc deleted the tx_gas_price_1559 branch April 22, 2024 10:02
@lispc lispc restored the tx_gas_price_1559 branch April 23, 2024 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants