Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

DreamWuGit
Copy link

@DreamWuGit DreamWuGit commented Mar 14, 2024

Description

  • The TxAccessListGadget under constrains the RW delta counter
  • The EcPairingGadget under constrains the input_mod_192_is_zero
    variable
  • The tx_l1_fee gadget might be under constrained, adding constrain l1_fee_word zero if it is l1 msg tx
  • tx gas price as effective gas for eip1559

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@icemelon
Copy link
Member

@DreamWuGit Could you make 1 fix pr per finding?

@DreamWuGit
Copy link
Author

DreamWuGit commented Mar 16, 2024

@DreamWuGit Could you make 1 fix pr per finding?

@icemelon sure !

@DreamWuGit
Copy link
Author

split done & last one is PR #1152 ,

@DreamWuGit DreamWuGit closed this Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants