Use script glow status to track whether the project is running #3912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of calculating the number of monitor threads and subtracting it from the total number of threads, just check whether any non-monitor threads exist. We don't need to know how many there are, just whether any exist. This lets us get rid of _getMonitorThreadCount and convert the _nonMonitorThreadCount property to a boolean.
adroitwhiz
force-pushed
the
edge-activated-flag
branch
from
c589448 to
d663ba2
Compare
This means that: - Monitor blocks don't count, because they don't affect block glow (the monitor block container has forceNoGlow set) - Edge-activated hats with no stacks attached don't count (the block to glow is null) - Edge-activated hats whose predicates are false don't count (they're evaluated outside stepThreads so block glow isn't set to true) Basically, anything which would cause blocks to glow will cause the project to be considered "running".
For some reason, this wasn't getting respected anyway and flyout blocks were glowing anyway. Now that we're using block glow to track project run status, set forceNoGlow to false on the flyout blocks so that clicking one still counts as making the project run, like it did before the previous commit.
adroitwhiz
force-pushed
the
edge-activated-flag
branch
from
d663ba2 to
244b9d3
Compare
|
@Wowfunhappy See if this fixes the issue you found with #2419. |
|
@adroitwhiz It does, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #1948
Closes #2419
Proposed Changes
Reason for Changes
This fixes edge-activated hat blocks causing the project to always count as "running" and making the green flag appear active even if no scripts are running.
The system for tracking script glows is much more robust and accurate than the system that was previously used for determining if the project was running, so we should make use of that.
The rationale for each change is described in the corresponding commit message.
Test Coverage
Tested manually, and existing tests pass.
Here's what you should look for when testing this: