Don't emit PROJECT_RUN_START for edge activation check thread

[apple502j]

Resolves

Resolves #1948

Proposed Changes

• Counts number of threads that are edge-activated
• Exclude the threads from PROJECT_RUN_START checks

Reason for Changes

All edge-activated hats will be executed once per tick at _step, triggering PROJECT_RUN_START, which makes the green flag GUI "stuck" at active state. This is also compatibility issue; Scratch 2.0 didn't have this problem.

Test Coverage

tested in vivo(aka in my browser)

[Wowfunhappy]

@apple502j One issue I noticed—while this pull request fixes #1948 in the general case, the problem remains if the program was stopped via a stop all block.

Test project attached:
Pull 2419 Issue.sb3.zip

[adroitwhiz]

I think this also just doesn't count any scripts started by edge-activated hat blocks as "running".

[Wowfunhappy]

I think this also just doesn't count any scripts started by edge-activated hat blocks as "running".

No, that part seems to work for me, at least in terms of the active state of the green flag. When an edge-activated hat is triggered, the green flag becomes active until the script finishes, at which point the flag becomes inactive. It's just stop all that seems to screw things up.

[apple502j]

Well, updating 2.5 years old PR definitely sounds like a good idea... I'll try

[Wowfunhappy]

@apple502j Before you do, note that @adroitwhiz just made a separate fix: #3912