Show customized alerts on hardware extension peripheral errors. #1607
Conversation
| this._runtime.emit(this._runtime.constructor.PERIPHERAL_ERROR); | ||
| this._runtime.emit(this._runtime.constructor.PERIPHERAL_ERROR, { | ||
| message: `Scratch lost connection to`, | ||
| extensionId: this._extensionId |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| this.disconnect(); | ||
| // log.error(`BLE error: ${JSON.stringify(e)}`); | ||
| this._runtime.emit(this._runtime.constructor.PERIPHERAL_ERROR); | ||
| this._runtime.emit(this._runtime.constructor.PERIPHERAL_ERROR, { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
Like we discussed off-thread, let's address these in a follow-up.
|
Great! Will wait for scratchfoundation/scratch-gui#3209 to land to merge this. Thanks. |
|
I think you want to merge in the other order, don't you? After you land this one, wait for the new |
|
Oh, I see! I had not done that process yet myself, but I will try it now for these PRs, thanks. |
4 participants
Resolves
This is progress towards: scratchfoundation/scratch-gui#2956.
Proposed Changes
Shows customized alerts for peripheral errors/disconnections including extension icon and name.
Reason for Changes
To warn the user that a peripheral has disconnected and blocks may no longer work.
Notes