Skip to content

unflakify four blocks integration tests #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2020
Merged

unflakify four blocks integration tests #5491

merged 1 commit into from
Mar 6, 2020

Conversation

@benjiwheeler
Copy link
Contributor

@benjiwheeler benjiwheeler commented Mar 2, 2020

Resolves

Proposed Changes

  • adds findByXpath to wait for updated or new items to appear
  • adds an ENTER keypress

both are intended to allow callbacks to be called before we unmount the Costumes or Sounds tab.

@benjiwheeler benjiwheeler self-assigned this Mar 2, 2020
@benjiwheeler
Copy link
Contributor Author

benjiwheeler commented Mar 3, 2020 •
edited
Loading

Next step: try running this on Travis a bunch of times

result: ran it 4 times, no errors!

@benjiwheeler benjiwheeler added this to the March 2020 milestone Mar 4, 2020
BryceLTaylor
BryceLTaylor approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@BryceLTaylor BryceLTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@benjiwheeler benjiwheeler merged commit a731370 into scratchfoundation:develop Mar 6, 2020
@benjiwheeler benjiwheeler deleted the unflakify-blocks-tests branch March 6, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BryceLTaylor BryceLTaylor BryceLTaylor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjiwheeler benjiwheeler

Labels

pr - good to merge

Projects

None yet

Milestone

March 2020

Development

Successfully merging this pull request may close these issues.

2 participants

@benjiwheeler @BryceLTaylor