Fix regex for extracting the project title from a .sb file #4195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisandagain
previously approved these changes
Dec 26, 2018
Contributor
There was a problem hiding this comment.
Thanks for tracking this down! Looks good, but it is failing a test:
FAIL test/unit/containers/sb-file-uploader.test.jsx
● SBFileUploader Container › sets blank title with .sb filename
expect(received).toBe(expected)
Expected value to be (using ===):
""
Received:
"my project is great"
at Object.<anonymous> (test/unit/containers/sb-file-uploader.test.jsx:75:25)
at new Promise (<anonymous>)
at <anonymous>
thisandagain
added
pr - good to merge
pr - changes requested
and removed
pr - needs review
pr - good to merge
labels
Contributor
Author
|
@thisandagain, thanks for catching that! I just updated the test. |
thisandagain
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex for extracting project titles was not previously structured to include .sb files. This was breaking the project title extraction now that we allow .sb files, and the project downloader was defaulting to attempting to download a file named sb3.zip.
Fix regex to make ending "2" or "3" optional in the extension.