Merge pull request #4195 from kchadha/fix-filename-regex

Fix regex for extracting the project title from a .sb file

Author: kchadha

src/containers/sb-file-uploader.jsx

@@ -80,8 +80,9 @@ class SBFileUploader extends React.Component {
     }
     getProjectTitleFromFilename (fileInputFilename) {
         if (!fileInputFilename) return '';
-        // only parse title from files like "filename.sb2" or "filename.sb3"
-        const matches = fileInputFilename.match(/^(.*)\.sb[23]$/);
+        // only parse title with valid scratch project extensions
+        // (.sb, .sb2, and .sb3)
+        const matches = fileInputFilename.match(/^(.*)\.sb[23]?$/);
         if (!matches) return '';
         return matches[1].substring(0, 100); // truncate project title to max 100 chars
     }

test/unit/containers/sb-file-uploader.test.jsx

@@ -65,14 +65,14 @@ describe('SBFileUploader Container', () => {
         expect(projectName).toBe('my project is great');
     });
 
-    test('sets blank title with .sb filename', () => {
+    test('correctly sets title with .sb filename', () => {
         const wrapper = shallowWithIntl(getContainer(), {context: {store}});
         const instance = wrapper
             .dive() // unwrap redux Connect(InjectIntl(SBFileUploader))
             .dive() // unwrap InjectIntl(SBFileUploader)
             .instance(); // SBFileUploader
         const projectName = instance.getProjectTitleFromFilename('my project is great.sb');
-        expect(projectName).toBe('');
+        expect(projectName).toBe('my project is great');
     });
 
     test('sets blank title with filename with no extension', () => {