Fix Sprinkles #803
Closed
Fix Sprinkles #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisandagain
suggested changes
Apr 20, 2017
There was a problem hiding this comment.
Thanks for the help @TheBrokenRail ! Unfortunately workspace is null here and thus this patch causes a fatal TypeError on page load.
paulkaplan
pushed a commit
to paulkaplan/scratch-blocks
that referenced
this pull request
May 5, 2017
…xml_function_rename Init procedure blocks with empty name, and set default name in xml in…
|
@TheBrokenRail please feel free to open a new PR if you would like to take another try at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
#739
Proposed Changes
Return toolbox instead of null.
Reason for Changes
Stress Testing