Skip to content

add description for punctuation removing #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2017
Merged

add description for punctuation removing #42

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc5bbe6
add description for punctuation removing
whalebot-helmsman Sep 8, 2017
05a658f
pep8 comments
whalebot-helmsman Sep 8, 2017
91d4225
pepier comments
whalebot-helmsman Sep 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions webstruct/text_tokenizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ class DefaultTokenizer(WordTokenizer):
def tokenize(self, text):
tokens = super(DefaultTokenizer, self).tokenize(text)
# remove standalone commas and semicolons
# as they broke tag sets, e.g. PERSON->FUNCTION in case "PERSON, FUNCTION"

# but it has negative consequences, e.g.
# etalon: [PER-B, PER-I, FUNC-B]
# predicted: [PER-B, PER-I, PER-I ]
# because we removed punctuation

# FIXME: remove as token, but save as feature left/right_punct:","
return [t for t in tokens if t not in {',', ';'}]


Expand Down