add description for punctuation removing #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 82.98% 82.98%
=======================================
Files 34 34
Lines 1704 1704
=======================================
Hits 1414 1414
Misses 290 290 |
kmike
reviewed
Sep 8, 2017
webstruct/text_tokenizers.py
Outdated
| @@ -109,7 +109,17 @@ def tokenize(self, text): | |||
| class DefaultTokenizer(WordTokenizer): | |||
| def tokenize(self, text): | |||
| tokens = super(DefaultTokenizer, self).tokenize(text) | |||
| # remove standalone commas and semicolons | |||
| """ | |||
There was a problem hiding this comment.
Could you please use a block comment, as per pep8 (i.e. start each line with #)? Or make this an actual docstring.
kmike
reviewed
Sep 8, 2017
webstruct/text_tokenizers.py
Outdated
| #but it has negative consequences, e.g. | ||
| #etalon: [PER-B, PER-I, FUNC-B] | ||
| #predicted: [PER-B, PER-I, PER-I ] | ||
| #because we removed punctuation |
There was a problem hiding this comment.
another nitpick, sorry! Could you please add a whitespace between # and the actual comment, to follow pep8? It may also help readability to add a # on empty line, as pep8 says
Paragraphs inside a block comment are separated by a line containing a single
#
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.