Add GitHub workflow for building and publishing #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add @kmike as reviewer. Hoping your PR gets approved! |
|
@costika1234 thanks! Unfortunately I can't directly assign him as this would require write access to this repo, but I hope he will notice the mention in your comment :) |
fgregg
requested changes
Mar 21, 2022
| CIBW_SKIP: "pp38-win_amd64" # FIXME | ||
| CIBW_BEFORE_BUILD: "pip install -U cython && ./update_cpp.sh" | ||
| CIBW_BEFORE_BUILD_WINDOWS: "pip install -U cython && update_cpp.sh" | ||
| CIBW_TEST_COMMAND: "echo Wheel installed successfully" |
There was a problem hiding this comment.
can you try:
CIBW_TEST_REQUIRES=tox
CIBW_TEST_COMMAND="cd {project} && tox"
There was a problem hiding this comment.
@Gerrit-K, looks like we are close. if we can figure out how to get tox to only run the relevant python version, then I think this can come in.
Yes, was about to comment something similar, but then left for dinner ;)
The question is whether we really need tox now, after all. As far as I understand it, it is designed to perform isolated testing across several python versions. Now, since cibuildwheel already provides isolated environments for the built wheels, couldn't we just simply run pytest instead of tox? Or is there more to it that I currently dont understand (yet)?
There was a problem hiding this comment.
i think directly calling pytest is good, let’s do that
There was a problem hiding this comment.
Alright, getting closer. All tests until PyPy 3.7 x64 succeed. That one fails on all OSes with SystemError: Function returned a NULL result without setting an exception. Any ideas?
There was a problem hiding this comment.
let's skip the failing pypy builds.
I think this is reasonable. |
Ah yes, sure, here you go: Logs |
|
@Gerrit-K, looks like we are close. if we can figure out how to get tox to only run the relevant python version, then I think this can come in. |
Gerrit-K
force-pushed
the
travis-to-github
branch
from
6473ceb to
a379099
Compare
For non-windows builds, the wheels could actually be created but didn't pass the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple GitHub workflow to build and publish wheels using cibuildwheel (mostly inspired by their example). It's probably nowhere near perfect, but should hopefully get things started again.
Some things to (re)consider / discuss:
CIBW_SKIP(seeFIXMEcomment). If anyone wants to take a look into this, feel free.CIBW_TEST_COMMAND), mostly because I didn't find a quick solution on how to runtoxfrom within the isolated cibuildwheel environments. Again, any help or hints on this are welcome.pypi_passwordcontaining an upload token.Any feedback is highly appreciated!
Refs: #130, #139, #140