-
Notifications
You must be signed in to change notification settings - Fork 488
Added Fix for "x days from now" #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
==========================================
- Coverage 95.21% 95.21% -0.01%
==========================================
Files 302 302
Lines 2507 2506 -1
==========================================
- Hits 2387 2386 -1
Misses 120 120
Continue to review full report at Codecov.
|
|
Any particular reason why this is failing? |
|
Don’t mind the project coverage test. The tests pass and you have covered your changes with tests. |
Gallaecio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you seen https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data ? I think you may have missed some steps. Also applies to #638 and #650.
|
I am getting this Error @Gallaecio |
|
I changed the following wherever the error occurred in scripts/write_complete_data.py Is this the right way? |
In cases where the read data goes into |
fixes #502
Before:
After: