-
Notifications
You must be signed in to change notification settings - Fork 488
fix: allow 'N {interval} from now' (#502) #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Can we get this merged? Would like to have support for "* from now" format |
|
Closing and reopening to see if CI triggers. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 235 235
Lines 2866 2866
=======================================
Hits 2768 2768
Misses 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems tests do not pass. |
Fixes test failure by moving "from now" test cases from test_relative_past_dates to test_relative_future_dates.
|
The test cases were decorating the wrong function, they should pass now. |
|
Any further news on this? This is perhaps the most common timedelta construction in natural language English. |
This is a copy of PR #642 which fixes #502. I'm not sure why it was closed, or if this is the right way to re-submit it. Afaict it's a general fix that works in all cases.
Before:
After: