Skip to content

Add deactivatePricer #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 6, 2025
Merged

Add deactivatePricer #973

merged 8 commits into from
May 6, 2025

Conversation

Joao-Dionisio
Copy link
Member

@Joao-Dionisio Joao-Dionisio commented Apr 14, 2025

This is useful if one wants to go for the Price and Branch heuristic in the middle of pricing

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/pyscipopt/scip.pxd: Language not supported
  • src/pyscipopt/scip.pxi: Language not supported
Comments suppressed due to low confidence (2)

tests/test_pricer.py:72

  • Confirm that passing 'self' as a parameter to deactivatePricer matches its expected signature. If the pricer instance should be passed instead, update the argument accordingly.
self.model.deactivatePricer(self)

tests/test_pricer.py:236

  • Consider adding an assertion directly verifying that the pricer deactivation is in effect after s.optimize(), enhancing the test coverage for the new functionality.
s.optimize()

@Joao-Dionisio Joao-Dionisio requested a review from mmghannam April 15, 2025 10:35
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.46%. Comparing base (1db095e) to head (18160e8).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
src/pyscipopt/scip.pxi 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   52.54%   53.46%   +0.92%     
==========================================
  Files          20       22       +2     
  Lines        4345     4962     +617     
==========================================
+ Hits         2283     2653     +370     
- Misses       2062     2309     +247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Joao-Dionisio Joao-Dionisio enabled auto-merge (squash) May 6, 2025 13:09
@Joao-Dionisio Joao-Dionisio merged commit 5f65812 into master May 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants