Skip to content

Add access functions for row duals #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025
Merged

Conversation

chrhansk
Copy link
Contributor

@chrhansk chrhansk commented May 5, 2025

Could you please add those and ideally release a new version? I need those functions for a project.

@Joao-Dionisio
Copy link
Member

Hey, @chrhansk sure! Would you mind adding a quick test, please? Perhaps something in tests/test_lp.py, create a small LP and assert that the result is what you'd expect.

And releasing a new version would be no problem at all, there's a bugfix that we wanted to get out.
But just to make sure, do you know how you can compile your local version of pyscipopt? It would be another possibility for you.

@chrhansk
Copy link
Contributor Author

chrhansk commented May 6, 2025

I added a small test and updated the Changelog. Problem with the test is that the LP interface does not seem to operate with rows. The test therefore adds a cut and then checks for dual activity after resolving the LP relaxation. The test is unfortunately a bit more fragile, since all other separators have to be deactivated for it to work...

@Joao-Dionisio
Copy link
Member

Thank you, @chrhansk! As for the new release, let me just wait on a review for #973, I think it should be done by the end of the week.

@Joao-Dionisio Joao-Dionisio self-requested a review May 6, 2025 12:49
@Joao-Dionisio Joao-Dionisio enabled auto-merge (squash) May 6, 2025 12:49
@Joao-Dionisio Joao-Dionisio merged commit a8daa5c into scipopt:master May 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants