Rerestructure requirements after #171 #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
reviewed
Apr 11, 2023
PicoCentauri
force-pushed
the
requirements_clean
branch
from
ab356e6 to
c76111c
Compare
PicoCentauri
force-pushed
the
requirements_clean
branch
from
c76111c to
da357d9
Compare
agoscinski
approved these changes
Apr 11, 2023
Collaborator
agoscinski
left a comment
agoscinski
left a comment
There was a problem hiding this comment.
Thanks comments make this clearer
PicoCentauri
added a commit
that referenced
this pull request
Apr 11, 2023
PicoCentauri
added a commit
that referenced
this pull request
Apr 11, 2023
PicoCentauri
added a commit
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a little aftermath to #171 this PR resorts the requirements for the examples.
Background: The requirements for the examples do not live in an extra file in examples anymore but can be installed directly when skmatter is installed using
This avoids duplications and makes it easier for users to work with our examples.
📚 Documentation preview 📚: https://scikit-matter--183.org.readthedocs.build/en/183/