Skip to content

fix: Use str object for jupyterlite-sphinx jupyterlite_dir config #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2024
Merged

fix: Use str object for jupyterlite-sphinx jupyterlite_dir config #2458

merged 2 commits into from
Mar 22, 2024

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 20, 2024 •
edited
Loading

Description

  • To avoid warning
WARNING: The config value `jupyterlite_dir` has type `PosixPath`, defaults to `str`.

use a str for the jupyterlite-sphinx v0.13.0+ jupyterlite_dir config option.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* To avoid warning

WARNING: The config value `jupyterlite_dir` has type `PosixPath`, defaults to `str`.

 use a str for the jupyterlite-sphinx v0.13.0+ jupyterlite_dir config
 option.
* Update jupyterlite-sphinx lower bound to v0.13.1 in 'docs' extra.
* Amends PR https://github.com/scikit-hep/pyhf/pull/2300

@matthewfeickert matthewfeickert added docs Documentation related fix A bug fix need-to-backport tmp label until can be backported to patch release branch labels Mar 20, 2024
@matthewfeickert matthewfeickert self-assigned this Mar 20, 2024
@matthewfeickert matthewfeickert marked this pull request as draft March 20, 2024 00:15
@codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (428c9e1) to head (c4652d0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2458   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert mentioned this pull request Mar 20, 2024
Closed
matthewfeickert
matthewfeickert commented Mar 20, 2024
View reviewed changes
@matthewfeickert
fix: Use str object for jupyterlite-sphinx jupyterlite_dir config
32cc93c 
* To avoid warning

WARNING: The config value `jupyterlite_dir' has type `PosixPath', defaults to `str'.

 use a str for the jupyterlite-sphinx v0.13.1+ jupyterlite_dir config
 option.
* Update jupyterlite-spinx lower bound to v0.13.1 in 'docs' extra.
* Reverts PR https://github.com/scikit-hep/pyhf/pull/ 2300
@matthewfeickert matthewfeickert force-pushed the docs/fix-jupyterlite-dir-path branch from 03c7e10 to 32cc93c Compare March 22, 2024 15:03
@matthewfeickert matthewfeickert marked this pull request as ready for review March 22, 2024 15:08
@matthewfeickert matthewfeickert merged commit 39db83b into main Mar 22, 2024
@matthewfeickert matthewfeickert deleted the docs/fix-jupyterlite-dir-path branch March 22, 2024 15:36
@matthewfeickert matthewfeickert mentioned this pull request May 30, 2024
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request May 30, 2024
@matthewfeickert
ci(backport): Update GitHub Actions (#2493)
290a23c 
* Backport:
   - PR #2443
   - PR #2446
   - PR #2451
   - PR #2458
   - PR #2460
   - PR #2465
   - PR #2468
   - PR #2471
   - PR #2472
@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 30, 2024

@meeseeksdev backport to release/v0.7.x

meeseeksmachine pushed a commit to meeseeksmachine/pyhf that referenced this pull request May 30, 2024
@matthewfeickert @meeseeksmachine
Backport PR scikit-hep#2458: fix: Use str object for jupyterlite-sphi…
272df9d 
…nx jupyterlite_dir config
@meeseeksmachine meeseeksmachine mentioned this pull request May 30, 2024
Merged
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 30, 2024
matthewfeickert added a commit that referenced this pull request May 30, 2024
@meeseeksmachine @matthewfeickert
fix(backport): Use str object for jupyterlite-sphinx jupyterlite_dir …
1dec306 
…config (#2501)

* Backport PR #2458
* To avoid warning

WARNING: The config value `jupyterlite_dir` has type `PosixPath`, defaults to `str`.

 use a str for the jupyterlite-sphinx v0.13.0+ jupyterlite_dir config
 option.

Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@matthewfeickert matthewfeickert

Labels

docs Documentation related fix A bug fix

Projects

pyhf v0.8.0
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewfeickert