fix: Correct syntax in jupyter lite command list #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing comma between commands. * Removes dangling '--' that does not connect additional extra commands.
This was referenced Mar 20, 2024
Collaborator
|
Sorry it seems one cannot actually pass doit options to jupyterlite build like this and have them take affect. The output was only being suppressed because the command was failing. 0.13.0 will need to be yanked and further work will be needed to suppress the output. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends PR #150
These changes unbreak scikit-hep/pyhf#2458, and so should be minimally sufficient, though additional tests should be applied.
Tagging @steppi and @Carreau for review.