Skip to content

Conversation

@matthewfeickert
Copy link
Member

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport:
   - PR https://github.com/scikit-hep/pyhf/pull/2181
   - PR https://github.com/scikit-hep/pyhf/pull/2199
   - PR https://github.com/scikit-hep/pyhf/pull/2201

@matthewfeickert matthewfeickert added docs Documentation related backport Backport PRs from main to release branch labels May 16, 2023
@matthewfeickert matthewfeickert self-assigned this May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.7.x@1009399). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2202   +/-   ##
=================================================
  Coverage                  ?   98.30%           
=================================================
  Files                     ?       69           
  Lines                     ?     4532           
  Branches                  ?      801           
=================================================
  Hits                      ?     4455           
  Misses                    ?       45           
  Partials                  ?       32           
Flag Coverage Δ
contrib 27.51% <0.00%> (?)
doctest 61.12% <0.00%> (?)
unittests-3.11 96.31% <0.00%> (?)
unittests-3.8 96.33% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

Though the CI is breaking, we can merge this given tensorflow/probability#1723.

@matthewfeickert matthewfeickert merged commit 8686b08 into release/v0.7.x May 16, 2023
@matthewfeickert matthewfeickert deleted the backport/use-citations branch May 16, 2023 06:09
@matthewfeickert
Copy link
Member Author

Fixed in PR #2203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backport PRs from main to release branch docs Documentation related

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants