Skip to content

fix: allow overwriting labels for plot/overlay #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2022
Merged

fix: allow overwriting labels for plot/overlay #414

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19c9802
fix: allow overwriting labels for plot/overlay
andrzejnovak Jun 7, 2022
3574e0c
style: pre-commit fixes
pre-commit-ci[bot] Jun 27, 2022
45ab446
fix: review
andrzejnovak Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/hist/basehist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,19 @@ def plot1d(
cat_ax = self.axes[overlay]
cats = cat_ax if cat_ax.traits.discrete else np.arange(len(cat_ax.centers))
d1hists = [self[{overlay: cat}] for cat in cats]
if "label" in kwargs:
if not isinstance(kwargs["label"], str) and len(kwargs["label"]) == len(
cats
):
cats = kwargs["label"]
kwargs.pop("label")
elif isinstance(kwargs["label"], str):
cats = [kwargs["label"]] * len(cats)
kwargs.pop("label")
else:
raise ValueError(
f"label ``{kwargs['label']}`` not understood for {len(cats)} categories"
)
return plot.histplot(d1hists, ax=ax, label=cats, **_proc_kw_for_lw(kwargs))

def plot2d(
Expand Down