fix: allow overwriting labels for plot/overlay #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amangoel185
approved these changes
Jun 17, 2022
henryiii
reviewed
Jun 21, 2022
src/hist/basehist.py
Outdated
| cats = cat_ax if cat_ax.traits.discrete else np.arange(len(cat_ax.centers)) | ||
| d1hists = [self[{overlay: cat}] for cat in cats] | ||
| if "label" in kwargs: | ||
| if isinstance(kwargs["label"], list) and len(kwargs["label"]) == len(cats): |
There was a problem hiding this comment.
Does it have to be a list? Couldn't it be any arbitrary collection? Except a string. I assume you are trying not to match on a string?
henryiii
reviewed
Jun 27, 2022
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
henryiii
approved these changes
Jun 27, 2022
|
Thanks! I think we are planning on a release later in the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.