Skip to content

Conversation

@samuelveigarangel
Copy link
Contributor

O que esse PR faz?

  • Altera ordem do elemento 'month' na classe DataPipe.
  • Altera XMLArticleMetaContribGroupPipe para criar elemento apenas se o valor de "role" igual 'ND' ou 'ED'

Onde a revisão poderia começar?

pelos commits

Como este poderia ser testado manualmente?

executar o teste:
python python -m unittest article_meta.tests.test_xml_citation_date_with_year_and_month_and_day_pipe
python python -m unittest article_meta.tests.test_xmlarticle_meta_contrib_group_author_names_pipe

Algum cenário de contexto que queira dar?

N/A

Screenshots

N/A

Quais são tickets relevantes?

#294
#292

Referências

N/A

Comment on lines +241 to +242
"month": raw.publication_date[5:7],
"year": raw.publication_date[0:4]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelveigarangel não necessariamente garante a ordem

@robertatakenaka robertatakenaka merged commit b5ad50f into scieloorg:master Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants