chm-878 New legal framework overview edit form

[Mitch1000]

General description

Creating an edit form for the new common format Legal Framework Overview

Task: CHM-878
Parent: CHM-852

Designs

Design document can be found in issue CHM-852.

Testing instructions

1. Visit the new LFO page: http://localhost:2010/en/register/LFO/new
2. Click the Submission form navigation header below the Legal Framework Overview (LFO) header.
3. Ensure the form that appears matches the form described in the Word document in issue CHM-852.
4. Visit the LFO documents list page http://localhost:2010/en/register/LFO/status/drafts
5. Click the edit button next to an existing LFO document.
6. Ensure the edit page appears populated with the expected data under the Submission form header.
7. Review the code.

Checklist before merging

• Branch name / PR includes the related Jira ticket Id.
• Tests to check core implementation / bug fix added.
• All checks in Continuous Integration workflow pass.
• Feature functionally tested by reviewer(s).
• Code reviewed by reviewer(s).
• Documentation updated (README, CHANGELOG...) (if required)

NOTE:

The following files come from existing PR #1467 and can be ignored.

app/types/common/document-report.ts
app/types/common/documents.ts

[blaisefonseca]

Suggested change

	$scope.header = { indentifier: '', schema: '', languages: [] }
	$scope.header = { identifier: '', schema: '', languages: [] }

[blaisefonseca]

can you make sure all questions have number?

[blaisefonseca]

why are you passing vue t function here, can we not do it just like the nr reports are doing?

[blaisefonseca]

mixing text this way will be a problem for translators, we need to have a better way for this. can we explore markdown?

[Mitch1000]

This is one potential solution: https://vue-i18n.intlify.dev/guide/essentials/syntax#custom-modifiers

Can we discuss this further?

[blaisefonseca]

The interface is not in sync with the backend schema

import { ETerm } from "./eTerm";
import { lstring } from "./lstring";
import { NrResponse } from "./nrResponse";
import { EHeader } from "./eHeader";
import { ELink } from "./eLink";

export interface EAbsLegalFramework extends ENationalRecordBase {
    jurisdiction: ETerm;
    jurisdictionImplementation: lstring;
    establishedMesasure: NrResponse;
    agrSubjectToPic: NrResponse<lstring>;
    agrMesasureForAccess: NrResponse<lstring>;
    agrCommercialPermitRequired: NrResponse<lstring>;
    agrCommercialPermitException: NrResponse<lstring>;
    agrNonCommercialPermitRequired: NrResponse<lstring>;
    agrNonCommercialPermitException: NrResponse<lstring>;
    tkSubjectToPic: NrResponse<lstring>;
    tkMesasureForAccess: NrResponse<lstring>;
    tkCommercialPermitRequired: NrResponse<lstring>;
    tkCommercialPermitException: NrResponse<lstring>;
    tkNonCommercialPermitRequired: NrResponse<lstring>;
    tkNonCommercialPermitException: NrResponse<lstring>;
    article53Implemented: NrResponse<lstring>;
    article55Implemented: NrResponse<lstring>;
    article15Implemented: NrResponse<lstring>;
    article16Implemented: NrResponse<lstring>;
    article17Implemented: NrResponse<lstring>;
}

export interface ENationalRecordBase extends ERecordBase {
    government: ETerm;
}

export interface EReferenceRecordBase extends ERecordBase {

}

export interface ERecordBase {
    header: EHeader;
    additionalInformation: lstring;
    additionalDocuments: ELink[];
    notes: string;
}```

[blaisefonseca]

    value: V;
    additionalInformation: T;
}

export interface NrLinkResponse {
    url: string;
    name: string;
    tags: string;
    language: string;
}

export interface NrLinkResponse<T> {
    additionalInformation: T;
    links: NrLinkResponse[];
}```

[blaisefonseca]

here you should clean values if they are not required. for eg. if they answer Yes to a question that required additional info and then if they switch the answer to no, then additional info is not required and will not be accepted by backend.

[blaisefonseca]

not a big deal, thesaurus is anonymous access, no need to pass token

[blaisefonseca]

this should be a computed prop

[blaisefonseca]

can me move this logic to onMounted?

[blaisefonseca]

can you see how ebsa does the country loading and do it the same way?

[blaisefonseca]

see ebsa const options = { countries : thesaurusApi.getDomainTerms(THESAURUS.COUNTRIES), ebsaRegions : thesaurusApi.getDomainTerms(THESAURUS_EBSA_REGION) };