Skip to content

Show NR1 Information in Country Profile CHM-859#1467

Closed
Mitch1000 wants to merge 40 commits intomasterfrom
mitchell/nr1-on-country-profiles-CHM-859
Closed

Show NR1 Information in Country Profile CHM-859#1467
Mitch1000 wants to merge 40 commits intomasterfrom
mitchell/nr1-on-country-profiles-CHM-859

Conversation

@Mitch1000
Copy link
Collaborator

@Mitch1000 Mitch1000 commented Jan 9, 2026

General description

Displaying First National Report information in the countries profile if the country is missing key documents.

Issue: CHM-859 Show NR1 information if no national information on country profiles

Designs

Screenshot 2026-01-08 at 9 06 47 PM

Testing Instructions

  1. Run yarn to ensure all packages have been installed.
  2. Navigate to the country profile for a country that has a NR1 but no other information http://localhost:2010/en/countries/DZ?status=All
  3. Ensure questions are displayed at the bottom of the page according to the following criteria:
No ABS-NFP -  Q3
No CNA – Q4, 4.1, 4.2, 11
No CP – Q5, 5.1, 5.2
No MSR – Q7, 7.1
No CPC – Q21.1, 21.2, 21.3
No PROs – Q10, 10.1
No IRCCs – Q12, 12.1, 12.2
No NMCC – Q13, 13.1

  1. Review the code.

Checklist before merging

  • [ ✅] Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • [ ✅] All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • [✅ ] Documentation updated (README, CHANGELOG...) (if required)

@Mitch1000 Mitch1000 changed the base branch from master to mitchell/adding-typescript-to-project-CHM-829 January 9, 2026 02:51
@Mitch1000 Mitch1000 force-pushed the mitchell/nr1-on-country-profiles-CHM-859 branch 14 times, most recently from b2f5c66 to 80bfbe2 Compare January 9, 2026 16:26
@Mitch1000 Mitch1000 marked this pull request as ready for review January 9, 2026 16:27
@Mitch1000 Mitch1000 force-pushed the mitchell/nr1-on-country-profiles-CHM-859 branch 5 times, most recently from 5bdf870 to 2dccd8d Compare January 13, 2026 00:07
Copy link
Contributor

@blaisefonseca blaisefonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass the report key as param

@Mitch1000 Mitch1000 self-assigned this Jan 13, 2026
@Mitch1000 Mitch1000 force-pushed the mitchell/adding-typescript-to-project-CHM-829 branch 2 times, most recently from a440b49 to cb0ee4a Compare January 14, 2026 15:42
@Mitch1000 Mitch1000 force-pushed the mitchell/nr1-on-country-profiles-CHM-859 branch from 997aa4f to 7f88a7d Compare January 20, 2026 22:49
@Mitch1000 Mitch1000 force-pushed the mitchell/nr1-on-country-profiles-CHM-859 branch from c8db8c8 to 625bf6c Compare January 20, 2026 23:00
@Mitch1000 Mitch1000 force-pushed the mitchell/nr1-on-country-profiles-CHM-859 branch from eb809cc to caf43d3 Compare January 21, 2026 15:51
@Mitch1000 Mitch1000 force-pushed the mitchell/nr1-on-country-profiles-CHM-859 branch from ca66c03 to 4ef7714 Compare February 3, 2026 01:27
@blaisefonseca
Copy link
Contributor

Closing this PR as this requirement is no longer required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments