Skip to content

fix: exception when 'filter_sort' block is missing#303

Open
robaimes wants to merge 1 commit intoscandiweb:mainfrom
robaimes:sorter-fix
Open

fix: exception when 'filter_sort' block is missing#303
robaimes wants to merge 1 commit intoscandiweb:mainfrom
robaimes:sorter-fix

Conversation

@robaimes
Copy link
Collaborator

@robaimes robaimes commented Jan 22, 2026

Pull Request Template

Thank you for contributing to the Satoshi Theme! Please provide the following information about your changes:

Summary

Prevent rendering of 'Sort by' elements where the block /data is not available

Type of Change

Please check the relevant option:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement (refactoring, optimization, etc.)

Related Issues

Changes Made

  • Added safeguarding against $sorter->{method} calls in case
  • Prevent output of 'Sort by' when relevant data is not available

Testing

Please describe how you tested your changes:

  • Tested in development environment
  • Tested on desktop browsers
  • Tested on mobile devices
  • Performance impact evaluated
  • Cross-browser compatibility checked

Test Environment

Magento Version: 2.4.8-p3
Hyva Theme Version: 1.3.21
PHP Version: 8.4.14 (with #302)
Testing Browsers: Chrome

Screenshots/Videos

If applicable, add screenshots or videos demonstrating the changes.

Performance Impact

  • No performance impact
  • Performance improvement
  • Potential performance impact (please explain)

Documentation

  • Code is self-documenting
  • Added/updated inline comments where needed
  • Updated README.md (if applicable)
  • Updated CONTRIBUTING.md (if applicable)

Checklist

Please confirm you have completed the following:

  • My code follows the project's coding standards
  • I have performed a self-review of my code
  • I have tested my changes thoroughly
  • My changes do not introduce any new warnings or errors
  • I have updated documentation where necessary
  • I have checked that my changes work with the latest Hyva theme version

Additional Notes

Add any additional context, concerns, or questions about this PR.

@robaimes robaimes mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems

1 participant