Open
Conversation
This was referenced Jan 22, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Thank you for contributing to the Satoshi Theme! Please provide the following information about your changes:
Summary
Fix class and method signatures to be compatible with PHP 8.4.
Type of Change
Please check the relevant option:
Related Issues
Changes Made
?when necessaryTesting
Please describe how you tested your changes:
Test Environment
Magento Version:
2.4.8-p2and2.4.8-p3Hyva Theme Version:
1.3.15and1.3.21PHP Version:
8.4.14Testing Browsers: Chrome
Screenshots/Videos
If applicable, add screenshots or videos demonstrating the changes.
Performance Impact
Documentation
Checklist
Please confirm you have completed the following:
Additional Notes
Technically, this introduces some breaking changes in the form of parameter reogranisation. Some optional parameters were being added before required ones which have been fixed.