Skip to content

fix: drawer animation #5593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

fix: drawer animation #5593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-stars-marry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ultraviolet/ui": patch
---

`Drawer`: fix animation on small
16 changes: 8 additions & 8 deletions packages/ui/src/components/Drawer/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,10 @@ exports[`drawer > renders with disclosure and onClose 1`] = `

@keyframes animation-1 {
from {
-webkit-transform: translateX(22rem);
-moz-transform: translateX(22rem);
-ms-transform: translateX(22rem);
transform: translateX(22rem);
-webkit-transform: translateX(21rem);
-moz-transform: translateX(21rem);
-ms-transform: translateX(21rem);
transform: translateX(21rem);
}

to {
Expand All @@ -223,10 +223,10 @@ exports[`drawer > renders with disclosure and onClose 1`] = `

@keyframes animation-1 {
from {
-webkit-transform: translateX(22rem);
-moz-transform: translateX(22rem);
-ms-transform: translateX(22rem);
transform: translateX(22rem);
-webkit-transform: translateX(21rem);
-moz-transform: translateX(21rem);
-ms-transform: translateX(21rem);
transform: translateX(21rem);
}

to {
Expand Down
19 changes: 13 additions & 6 deletions packages/ui/src/components/Drawer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const SIZES = {
// 1 rem = 16 px
small: 22.25,
}

const slideIn = (translation: number) => keyframes`
from {
transform: translateX(${translation}rem);
Expand All @@ -28,14 +29,20 @@ const slideIn = (translation: number) => keyframes`
`

const slideAnimation = (size: 'small' | 'medium' | 'large') => {
if (size === 'small') {
return css`animation: ${slideIn(22)} linear 150ms;`
}
if (size === 'medium') {
return css`animation: ${slideIn(48)} linear 250ms;`
const translations = {
large: 70,
medium: 48,
small: 21,
} as const

const animationDuration = {
large: 300,
medium: 250,
small: 150,
}
const animation = slideIn(translations[size])

return css`animation: ${slideIn(70)} linear 300ms;`
return css`animation: ${animation} linear ${animationDuration[size]}ms;`
}

const StyledModal = styled(Modal)`
Expand Down
Loading