Skip to content

Conversation

@lisalupi
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Drawer: fix animation on small

@lisalupi lisalupi requested a review from a team September 25, 2025 08:53
@lisalupi lisalupi self-assigned this Sep 25, 2025
@lisalupi lisalupi requested review from DorianMaliszewski and vincentaudebert and removed request for a team September 25, 2025 08:53
@lisalupi lisalupi added the bug Something isn't working label Sep 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: 14fc74e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.20%. Comparing base (bdfd63a) to head (14fc74e).
⚠️ Report is 2 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             beta    #5593   +/-   ##
=======================================
  Coverage   92.19%   92.20%           
=======================================
  Files         274      276    +2     
  Lines        7807     7787   -20     
  Branches     3264     3287   +23     
=======================================
- Hits         7198     7180   -18     
+ Misses        609      607    -2     
Files with missing lines Coverage Δ
packages/ui/src/components/Drawer/index.tsx 97.43% <100.00%> (-0.07%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad2c9a...14fc74e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lisalupi lisalupi force-pushed the fix/drawer-animation branch from 791bb8f to 14fc74e Compare September 25, 2025 13:53
@lisalupi lisalupi merged commit 245d454 into beta Sep 25, 2025
40 of 43 checks passed
@lisalupi lisalupi deleted the fix/drawer-animation branch September 25, 2025 14:05
matthprost pushed a commit that referenced this pull request Oct 7, 2025
lisalupi added a commit that referenced this pull request Oct 22, 2025
lisalupi added a commit that referenced this pull request Nov 20, 2025
renovate bot added a commit that referenced this pull request Nov 20, 2025
* chore: beta opening (#5429)

* chore: fix changeset (#5430)

* feat(Button): emotion removal vanilla extract (#5428)

* feat(Button): emotion removal vanilla extract

* fix: unit tests and checks

* fix: update prefix to add uv

* fix: snapshot update

* chore: release (beta) (#5427)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: changeset for release of themes (#5433)

* chore: release (beta) (#5434)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: theme provider to inject theme in head (#5435)

* chore: release (beta) (#5436)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix(Snippet): remove after element on most of the lines (#5437)

* fix(Snippet): remove after element on most of the lines

* fix: feedback

* fix(TextArea): take all space when tooltip set (#5445)

* fix(form): remove all emotion usages (#5439)

* fix(form): remove all emotion usages

* fix: snapshots

* fix(Button): space in the class name (#5438)

* fix(Button): wrong sizes (#5452)

* chore: release (beta) (#5451)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* feat: open prop expandable card (#5431)

* fix: style on individual stories (#5465)

* fix: useCases category icon (#5462)

* feat: vanilla extract on badge and actionBar (#5461)

* feat: vanilla extract on badge and actionBar

* fix: create vanilla extract fadeIn animation

* chore: release (beta) (#5458)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: dialog size (#5468)

* refactor: vanilla extract banner and theme on stories (#5469)

* feat: banner vanilla extract

* fix: imports and format

* refactor: text and alert to vanilla extract (#5464)

* refactor: text and alert to vanilla extract

* fix: rebase

* fix: tests

* fix: rebase

* fix: tests (#5476)

* chore: release (beta) (#5471)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* feat(Avatar): use vanilla extract (#5467)

* fix: vanilla extract avatar

* fix: use css variables

* fix: tests

* refactor: vanilla extract on Separator and Loader (#5474)

* feat: vanilla extract separator and loader

* fix: use vanilla extract css var

* fix: add error message on code editor (#5479)

* fix: use css variables (#5478)

* fix: useless spacing classname on banner and button (#5488)

* feat(Popover): vanilla extract popup (#5477)

* feat: popup, popover and tooltip

* fix: var in new file

* fix: select bar on first render (#5493)

* chore: release (beta) (#5480)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: vanilla extract meter and barstack (#5494)

* feat: icons vanilla extract (#5481)

* feat: icons vanilla extract wip

* feat: update tests

* fix: changeset

* chore: release (beta) (#5505)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: stepList, status and notice vanilla extract (#5500)

* chore: release (beta) (#5427)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: release (beta) (#5434)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: steplist status and notice vanilla extract

* fix: feedback fabien

---------

Co-authored-by: Scaleway Bot <github@scaleway.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matthias <mprost@scaleway.com>

* refactor(Stack): vanilla extract (#5492)

* refactor(Stack): vanilla extract

* fix: add changeset

* fix: issue with css type

* refactor(row): vanilla extract (#5503)

* refactor(Row): use vanilla extract

* ci: add more tests

* fix: feedback alex

* fix: feedback alex

* fix(NumberInput): side buttons not working on re-render (#5527)

* feat: new illustration and product icon (#5528)

* fix(Stack): useless style added into the dom (#5531)

* refactor(Chip): use vanilla extract (#5532)

* fix(Snippet): indentation not working (#5534)

* chore: release (beta) (#5516)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: label and password check to vanilla extract (#5517)

* refactor: label and password check to vanilla extract

* fix: update snapshots

* fix(Navigation): add as prop on stack polymorphic component (#5546)

* chore: release (beta) (#5545)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: stack and row initial values on dynamic variables (#5547)

* fix(plus): order summary min-width, min-height (#5554)

* chore: release (beta) (#5557)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix(CodeEditor): to have fall back value when extension doesn't exists (#5560)

* chore: fix version make new major beta

* chore: release (beta) (#5562)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix(verificationCode): add htmlFor for label (#5573)

* refactor: global alert and expandable to use vanilla extract (#5530)

* refactor(radio): migrate to vanilla extract (#5533)

* refactor(radio): migrate to vanilla extract

* fix: typecheck and linter

* fix: feedback lisa

* fix: radio error

* refactor(VerificationCode): migrate to use vanilla extract (#5520)

* refactor(VerificationCode): migrate to use vanilla extract

* fix: unit tests

* refactor: progress bar to vanilla and fix badge (#5518)

* refactor: progress bar to vanilla and fix badge

* fix: feedback lisa

* fix: add class name and data test id on some components (#5581)

* fix: oulined and ghost button background color on hover (#5570)

* refactor: bullet and link vanilla extract (#5504)

* refactor: vanilla extract link and bullet

* fix: rebase

* fix: disabled should be a prop, not a sentiment

* fix: rebase

* fix: issue with prominence color link

* chore: release (beta) (#5574)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: card and tag vanilla extract (#5576)

* refactor: card and tag vanilla extract

* fix: sentiment style map

* fix: feedback

* fix: drawer animation (#5593)

* refactor: breadcrumbs vanilla extract and prop style to button (#5578)

* refactor: breadcrumbs vanilla extract and prop style to button

* fix: change child when onclick not defined

* fix: inject style in snapshots

* fix: remove fixed height breadcrumbs

* refactor: group input to use vanilla extract (#5580)

* refactor(ExpandableCard): to use vanilla extract and drop emotion (#5583)

* refactor(Checkbox): to use vanilla extract (#5577)

* fix: html tag select input option (#5586)

* fix(Icon): set correct promience on icons (#5595)

* fix(Icon): set correct promience on icons

* fix: current color

* chore: release (beta) (#5594)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix(SelectableCardOptionGroup): radio style (#5609)

* fix: selectable card option group radio style

* fix: tests

* refactor(SelectableCard): migration vanilla extract (#5596)

* refactor: vanilla extract selectableCard

* fix: style checkbox in selectable card

* chore: release (beta) (#5610)

* fix: rename clock icon (#5597)

* refactor: charts vanilla extract (#5582)

* refactor: chart components vanilla extract

* fix: feedback

* refactor(Skeleton): vanilla extract (#5598)

* refactor: skeleton vanilla extract

* fix: css variables

* feat: new logos (#5607)

* fix(Tag): html tag (#5616)

* fix: tag html

* fix: no div in span

* chore: release (beta) (#5612)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* feat: new product icon mailbox (#5617)

* refactor(NumberInput): vanilla extract (#5627)

* refactor: number input vanilla extract

* fix: feedback

* refactor: text area vanilla extract (#5631)

* fix(Checkbox): input size being wrong (#5639)

* chore: release (beta) (#5630)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: tagInput and tagList vanilla extract (#5614)

* refactor: tag input and tag list vanilla extract

* fix: add tests and improve accessibility

* refactor(TimeInput): vanilla extract (#5622)

* refactor: vanilla extract timeinput

* fix: feedback

* refactor: dateinput vanilla extract (#5624)

* refactor(TextInput): migrate to vanilla extract (#5608)

* refactor(TextInput): migrate to vanilla extract

* fix(TextInput): fix has focus issue

* fix: feedback lisa

* refactor: switch button vanilla extract (#5634)

* refactor: unit input vanilla extract (#5640)

* refactor(Toggle): to use vanilla extract (#5615)

* refactor(Toggle): to use vanilla extract

* fix: feedback lisa

* refactor(plus): refactor content card and configuration vanilla for plus package (#5628)

* chore: release (beta) (#5641)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* feat(icons): new system icons (#5633)

* fix: menu bottom overflow (#5656)

* fix: menu bottom overflow

* fix: add top placement fix

* refactor: search input vanilla extract (#5646)

* refactor: empty state vanilla extract (#5645)

* refactor: select input vanilla extract (#5644)

* refactor: faq vanilla extract (#5659)

* refactor(CodeEditor): vanilla extract (#5654)

* refactor: code editor vanilla extract

* fix: remove useless space

* fix: classname checkbox (#5660)

* chore: release (beta) (#5655)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: theme provider exported into themes package (#5632)

* refactor: theme provider exported into themes package

* fix: add theme provide and use theme back to ui

* fix: add theme provider in tests

* feat(OrderSummary): add additional info prop on sub categories (#5683)

* chore: release (beta) (#5680)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: modal and drawer vanilla extract (#5675)

* refactor: modal and drawer vanilla extract

* fix: delete useless file

* refactor: toaster and notification vanilla extract (#5662)

* fix(OrderSummary): time unit value correct width (#5661)

* refactor(ContentCardGroup): use vanilla extract (#5663)

* refactor(Pagination): to use vanilla extract (#5665)

* refactor: import fuzzy search from scaleway lib (#5653)

* refactor(Stepper): stepper vanilla extract (#5666)

* refactor: stepper vanilla extract

* fix: remove data attributes

* fix: add changeset

* refactor(carousel): use vanilla extract (#5664)

* refactor(carousel): use vanilla extract

* fix: feedback lisa

* refactor: snippet fanilla extract (#5651)

* fix(Table): select disabled not working properly (#5699)

* chore: release (beta) (#5686)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: dialog vanilla extract (#5705)

* fix: unit input style (#5689)

* fix: code editor copy button (#5706)

* refactor: infotable vanilla extract (#5714)

* refactor: conversation vanilla extract (#5716)

* refactor: menu vanilla extract (#5688)

* fix: breadcrumbs padding (#5719)

* feat: new logo ToucanToco (#5725)

* refactor: list and offerlist vanilla extract (#5698)

* fix: vite config (#5729)

* fix: vite config

* fix: snapshots

* chore(renovate): run renovate only on beta (#5727)

* fix(renovate): base branch

* fix(renovate): base branch on beta

* chore(devdeps): update pnpm to v10.19.0 (#5730)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(devdeps): update actions/setup-node action to v6 (#5732)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(npm): release management (#5735)

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>

* chore: release (beta) (#5717)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* refactor: slider (#5713)

* feat: mailbox illustration (#5738)

* fix: instances product icons (#5724)

* fix(action): update s3 vars (#5741)

* chore(devdeps): update dependency @biomejs/biome to v2.2.7 (#5739)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* refactor: customer satisfaction vanilla extract (#5718)

* refactor: tabs vanilla extract (#5723)

* refactor: table (#5726)

* fix: selectable card event propagation (#5745)

* fix: vanilla extract typos (#5749)

* fix: tagInput paste (#5746)

* fix: export toggle group field (#5748)

* fix: carousel width (#5744)

* fix: empty state text color (#5750)

* chore: release (beta) (#5736)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: e2e and theming (#5747)

* fix: button box shadow (#5753)

* refactor: plans vanilla extract (#5752)

* refactor(EstimateCost): vanilla extract (#5737)

* refactor: estimate cost vanilla extract

* fix: feedback

* refactor: steppedlistcard vanilla extract (#5755)

* refactor: navigation vanilla extract (#5743)

* refactor: ordersummary vanilla extract (#5751)

* refactor: line chart, selectable card option group, selectable card group and key (#5756)

* chore(devdeps): update eslint monorepo to v9.38.0 (#5760)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: release (beta) (#5754)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* feat: style prop (#5759)

* feat: style

* fix: format

* fix: missing component

* fix: style at the end

* fix: correct TagList maxLength prop (#5758)

* fix: content card disabled (#5763)

* fix: migration missing subcomponents (#5762)

* fix: migration SelectableCardOptionGroup subcomponents

* fix: migrate other missing components

* feat: component flags (#5761)

* fix(OfferList): selected row and first column style (#5767)

* fix: offer list selected

* fix: typo style

* fix: discount 100% ordersummary (#5770)

* fix: empty state title sentiment (#5772)

* chore: release (beta) (#5764)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: make sure to clear all timers when unmount Popup (#5771)

* fix(offerlist): forwards prominence to Badge (#5773)

* fix(offerlist): forwards prominence to Badge

* fix: add prominence on badge

---------

Co-authored-by: lisa <llupi@scaleway.com>

* chore: release (beta) (#5774)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: small mistake in CSS selector (#5776)

Co-authored-by: philibeaux <aphilibeaux@scaleway.com>

* feat(bundle): remove cjs (#5757)

* feat(cjs): remove cjs

* feat(cjs): remove cjs

* refactor: remove emotion from form, icons, illustrations and plus (#5768)

Co-authored-by: philibeaux <aphilibeaux@scaleway.com>

* chore(devdeps): update oxlint monorepo to v1.16.0 (#5566)

* chore(devdeps): update oxlint monorepo to v1.16.0

* fix: oxlint errors

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>

---------

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthias <mprost@scaleway.com>

* Revert "chore(devdeps): update oxlint monorepo to v1.16.0 (#5566)"

This reverts commit 88a4577.

* chore(oxlint): upgrade rule (#5778)

* chore(devdeps): update oxlint monorepo to v1.16.0

* fix: oxlint errors

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>

* chore(devdeps): update oxlint monorepo to v1.16.0 (#5566)

* chore(devdeps): update oxlint monorepo to v1.16.0

* fix: oxlint errors

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>

---------

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthias <mprost@scaleway.com>
Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>

---------

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthias <mprost@scaleway.com>

* refactor: remove emotion from tests and utils (#5769)

* refactor: remove emotion from tests and utils

* fix: typecheck

* fix: tests

* refactor: animations (#5766)

* feat: animations vanilla extract

* fix: redo animations

* feat(ui): add TreeMap chart (#5781)

* feat(ui): add TreeMap chart

* chore: use ResponsiveTreeMapHtml instead of ResponsiveTreeMap

* test: fix snapshots

* chore: lisa feedback

* chore: rename story

* refactor: remove emotion from examples (#5765)

* refactor: remove emotion from examples

* fix: remove emotion from nextjs

* fix: use scss for next example

* fix: feedback

* fix: update steppedlistcard (#5780)

* fix: update steppedlistcard

* fix: feedback

* fix: oneline infotable (#5783)

* fix: column width list (#5779)

* fix: diasbled flags (#5787)

* chore: release (beta) (#5777)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix(Popup): placement (#5782)

* fix: popup placement

* fix: add test

* fix: typing

* fix: typing

* fix: subcategory title (#5786)

* fix: pull request template (#5788)

* chore(devdeps): update dependency vite to v7.1.11 [security] (#5720)

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: philibeaux <aphilibeaux@scaleway.com>

* chore(devdeps): update dependency happy-dom to v20.0.10 (#5721)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency sass to v1.94.0 (#5793)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* refactor: remove emotion from storybook and ui (#5775)

* fix(devdeps): update nextjs monorepo to v16 (major) (#5731)

* fix(devdeps): update nextjs monorepo to v16

* chore: add changeset renovate-6ec49e6

* fix: rebase

* fix: wrong css and next config

* fix: next config

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Scaleway Bot <github@scaleway.com>
Co-authored-by: lisa <llupi@scaleway.com>

* fix: recompute popup position (#5789)

* feat: red-hat logo and close-circle icon (#5797)

* docs: showcase animations doc (#5792)

* feat(Alert): small version (#5791)

* feat: small alert

* fix: tests

* fix: icon size

* chore(devdeps): update actions/upload-artifact action to v5 (#5796)

* chore(devdeps): update dependency eslint-plugin-react-hooks to v7 (#5733)

* fix: tag input and text area size (#5798)

* chore: release (beta) (#5790)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: infotable oneLine bug (#5799)

* chore: release (beta) (#5800)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix(deps): update react monorepo

* chore: add changeset renovate-7774b7f

* chore: add changeset renovate-7774b7f

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>

---------

Signed-off-by: aphilibeaux <aphilibeaux@scaleway.com>
Co-authored-by: Matthias Prost <mprost@scaleway.com>
Co-authored-by: Scaleway Bot <github@scaleway.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lisalupi <106706307+lisalupi@users.noreply.github.com>
Co-authored-by: Levende <lmohammad@scaleway.com>
Co-authored-by: philibeaux <aphilibeaux@scaleway.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: etienne-scaleway <elefebvredeladonchamps@scaleway.com>
Co-authored-by: Vincent <vaudebert@scaleway.com>
Co-authored-by: lisa <llupi@scaleway.com>
Co-authored-by: radhi-nasser-scaleway <rnasser@scaleway.com>
Co-authored-by: Alexis Phuong <ahuynh.app@tuta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants