fix(lint): resolve lint issues #5100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5100 +/- ##
==========================================
- Coverage 57.47% 57.47% -0.01%
==========================================
Files 308 308
Lines 67193 67202 +9
==========================================
+ Hits 38621 38623 +2
- Misses 27134 27141 +7
Partials 1438 1438 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jremy42
force-pushed
the
fix/lint-preexisting-issues
branch
4 times, most recently
from
6d670c8 to
e26abc1
Compare
remyleone
reviewed
Oct 30, 2025
internal/interactive/list.go
Outdated
| func (m *ListPrompt) View() string { | ||
| s := m.Prompt + "\n\n" | ||
| var builder strings.Builder | ||
| builder.WriteString(m.Prompt) |
There was a problem hiding this comment.
Could all this calls be merged?
| builder.WriteString(fmt.Sprintf("> %s\n", choice)) | ||
| } else { | ||
| s += choice + "\n" | ||
| builder.WriteString(choice) |
| ) | ||
| for _, s := range sg.SecurityGroup.Servers { | ||
| hint += "\nscw instance server update " + s.ID + " security-group.id=$NEW_SECURITY_GROUP_ID" | ||
| hintBuilder.WriteString("\nscw instance server update ") |
jremy42
force-pushed
the
fix/lint-preexisting-issues
branch
from
e26abc1 to
f39810e
Compare
jremy42
changed the title
jremy42
force-pushed
the
fix/lint-preexisting-issues
branch
2 times, most recently
from
140fd90 to
0b89297
Compare
jremy42
force-pushed
the
fix/lint-preexisting-issues
branch
from
0b89297 to
f16e4a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: