fix: resolve preexisting lint issues (govet buildtag, perfsprint concat-loop)

Author: jremy42

core/cobra_utils_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"reflect"
+	"strings"
 	"testing"
 	"time"
 
@@ -84,16 +85,8 @@ func testGetCommands() *core.Commands {
 			ArgsType:             reflect.TypeOf(args.RawArgs{}),
 			AllowAnonymousClient: true,
 			Run: func(_ context.Context, argsI any) (i any, e error) {
-				res := ""
 				rawArgs := *argsI.(*args.RawArgs)
-				for i, arg := range rawArgs {
-					res += arg
-					if i != len(rawArgs)-1 {
-						res += " "
-					}
-				}
-
-				return res, nil
+				return strings.Join(rawArgs, " "), nil
 			},
 		},
 		&core.Command{

internal/gotty/resize_windows.go

@@ -1,5 +1,4 @@
 //go:build windows
-// +build windows
 
 package gotty
 

internal/interactive/list.go

@@ -8,6 +8,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"strings"
 
 	tea "github.com/charmbracelet/bubbletea"
 )
@@ -52,19 +53,21 @@ func (m *ListPrompt) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 }
 
 func (m *ListPrompt) View() string {
-	s := m.Prompt + "\n\n"
+	var builder strings.Builder
+	builder.WriteString(m.Prompt + "\n\n")
 
 	for i, choice := range m.Choices {
 		if m.cursor == i {
-			s += fmt.Sprintf("> %s\n", choice)
+			fmt.Fprintf(&builder, "> %s\n", choice)
 		} else {
-			s += choice + "\n"
+			builder.WriteString(choice)
+			builder.WriteByte('\n')
 		}
 	}
 
-	s += "\nPress enter or space for select.\n"
+	builder.WriteString("\nPress enter or space for select.\n")
 
-	return s
+	return builder.String()
 }
 
 // Execute start the prompt and return the selected index

internal/interactive/print.go

@@ -72,10 +72,5 @@ func RemoveIndent(str string) string {
 }
 
 func makeStr(char string, length int) string {
-	str := ""
-	for range length {
-		str += char
-	}
-
-	return str
+	return strings.Repeat(char, length)
 }

internal/namespaces/autocomplete/autocomplete.go

@@ -455,15 +455,17 @@ func TrimText(str string) string {
 	for i, line := range lines {
 		if !foundFirstNonEmptyLine {
 			if len(line) > 0 {
+				var builder strings.Builder
 				for _, c := range line {
 					if c == ' ' || c == '\t' {
-						strToRemove += string(c)
+						builder.WriteRune(c)
 
 						continue
 					}
 
 					break
 				}
+				strToRemove = builder.String()
 				foundFirstNonEmptyLine = true
 			}
 		}

internal/namespaces/init/init_test.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"path"
 	"regexp"
+	"strings"
 	"testing"
 
 	"github.com/scaleway/scaleway-cli/v2/core"
@@ -26,12 +27,13 @@ func checkConfig(
 }
 
 func appendArgs(prefix string, args map[string]string) string {
-	cmd := prefix
+	parts := make([]string, 0, len(args)+1)
+	parts = append(parts, prefix)
 	for k, v := range args {
-		cmd += fmt.Sprintf(" %s=%s", k, v)
+		parts = append(parts, fmt.Sprintf("%s=%s", k, v))
 	}
 
-	return cmd
+	return strings.Join(parts, " ")
 }
 
 func beforeFuncSaveConfig(config *scw.Config) core.BeforeFunc {

internal/namespaces/instance/v1/custom_security_group.go

@@ -314,12 +314,19 @@ func securityGroupDeleteBuilder(c *core.Command) *core.Command {
 				}
 
 				// Create detail message.
-				hint := "Attach all these instances to another security-group before deleting this one:"
+				lines := make([]string, 0, len(sg.SecurityGroup.Servers)+1)
+				lines = append(
+					lines,
+					"Attach all these instances to another security-group before deleting this one:",
+				)
 				for _, s := range sg.SecurityGroup.Servers {
-					hint += "\nscw instance server update " + s.ID + " security-group.id=$NEW_SECURITY_GROUP_ID"
+					lines = append(
+						lines,
+						"scw instance server update "+s.ID+" security-group.id=$NEW_SECURITY_GROUP_ID",
+					)
 				}
 
-				newError.Hint = hint
+				newError.Hint = strings.Join(lines, "\n")
 
 				return nil, newError
 			}

internal/sshconfig/bastion_host.go

@@ -1,6 +1,9 @@
 package sshconfig
 
-import "fmt"
+import (
+	"fmt"
+	"strings"
+)
 
 type BastionHost struct {
 	Name    string
@@ -11,22 +14,23 @@ type BastionHost struct {
 }
 
 func (b BastionHost) Config() string {
-	bastionConfig := fmt.Sprintf(`Host %s
+	parts := make([]string, 0, len(b.Hosts)+1)
+	parts = append(parts, fmt.Sprintf(`Host %s
   ProxyJump bastion@%s
 `,
 		b.name(),
-		b.address())
+		b.address()))
 
 	for _, host := range b.Hosts {
 		host.Name = fmt.Sprintf("%s.%s", host.Name, b.Name)
-		bastionConfig += fmt.Sprintf(`Host %s
+		parts = append(parts, fmt.Sprintf(`Host %s
   User %s
 `,
 			host.name(),
-			host.user())
+			host.user()))
 	}
 
-	return bastionConfig
+	return strings.Join(parts, "")
 }
 
 func (b BastionHost) name() string {