Correction from an absolute value to a relative value for wide screens. #17232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #17217 (main content suddenly getting too narrow at 1921px) seems to be fixed on latest main. As for the changes to the max-width, a 1920px it looks like this: If you feel up to it you can try to fix it, but with #17217 fixed I don't think it's that important. |
|
Okay perfect so, I can close it, thank you @Florian3k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have the absolute value in relative value, which allows the content to better adapt to screen sizes.
I didn't think it was necessary to add a media query to change the absolute value only at a certain screen size but I can do it if needed.
Before
2000px width
3000px width
After
2000px width
3000px width
Fixes: #17217