Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docs UI - page body width is too short, especially when maximizing the window #15871

Open
smarter opened this issue Aug 17, 2022 · 4 comments
Assignees
Labels
area:doctool itype:bug regression This worked in a previous version but doesn't anymore

Comments

@smarter
Copy link
Member

smarter commented Aug 17, 2022

See #15697 (comment) and #15697 (comment)
I also think that there's too much blank space in the "Attributes" section, the attribute name could be shown above its value instead of to the left to avoid that.

@smarter smarter added itype:bug area:doctool regression This worked in a previous version but doesn't anymore labels Aug 17, 2022
@szymon-rd szymon-rd self-assigned this Aug 18, 2022
@keynmol
Copy link
Contributor

keynmol commented Sep 15, 2022

Yeah currently on large (well, standard 27'') screens it looks quite weird:
image

It both truncates the snippets to unusable width and makes the text too jarring to read (too clustered to the left)

@Dedelweiss
Copy link
Contributor

Related to PR #17232
For the "Attributes" section, it would be a bit the same as in the mobile version, with the name of the attribute above the value? But on two columns in the Desktop version.

@Dedelweiss
Copy link
Contributor

Hello, I see that the problem isn't closed. Is it because it's not linked to a PR or because something hasn't been fixed yet?
As far as the width problem for wide screens is concerned, it seems to have been corrected in [issue 17217] (#17217).

For wide screen: 1922x1225

Screenshot 2023-06-06 at 15 00 32

But for 2560x1225(4k):

Screenshot 2023-06-06 at 15 08 38

Proposition:

So If the problem hasn't been solved because it hasn't been corrected for even larger screens.
I know that doing a fix for 4k screens would mean doing a fix for a very, very small proportion of users.
But I can propose a fix by changing the maximum width of #content > div:first-child from 720px to a percentage like 50% :

Result:

2560x1225:

Screenshot 2023-06-06 at 15 08 29

1922x1225:

Screenshot 2023-06-06 at 15 09 20

1470x1225 (Minimum that the max-width is active)

Screenshot 2023-06-06 at 15 13 22

@Gedochao Gedochao assigned Florian3k and unassigned szymon-rd Apr 8, 2024
@mbovel
Copy link
Member

mbovel commented Jul 8, 2024

Note that there are also important readability and accessibility criteria to consider, such as having 9-12 words per line, which take precedence over aesthetic concerns. This is similar to the reasoning behind wide margins in LaTeX—they serve a purpose.

While there probably is room for improvement, we should be cautious when making changes to these aspects, especially since the initial design was crafted by professional graphic designers, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:doctool itype:bug regression This worked in a previous version but doesn't anymore
Projects
None yet
Development

No branches or pull requests

6 participants