make Node.toString stack safe #677
Conversation
|
@lrytz are you going to merge this or should I do it? Thanks! |
|
@dubinsky feel free to go ahead. I might backport it to 1.x. Do you have any releases (1.x / 2.x) planned? |
I have one more change planned before the 2.2 release. |
The last 1.x release we did was in 2020. I see in the history on the 1.x branch that it has #418 where Lukas back ported the sbt-ci-release based publishing stuff, so there's a good chance we could publish there without too much extra trouble, but it would involve some extra trouble, for sure — for example, that branch still uses Travis-CI and not GitHub Actions, so that change ought to be backported. I can see one could argue it either way, but my own take on this stack safety issue that is that we shouldn't feel obligated to do another 1.x release on account of it. It's not that uncommon or unexpected for a library to overflow the stack when processing deeply nested input. Note that since 2.12.17, Scala 2.12 ships with scala-xml 2.x. |
### What changes were proposed in this pull request? This pr aims to upgrade `scala-xml` from 2.1.0 to 2.2.0. ### Why are the changes needed? The new version bring some bug fix like: - scala/scala-xml#651 - scala/scala-xml#677 The full release notes as follows: - https://github.com/scala/scala-xml/releases/tag/v2.2.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Actions - Checked Scala 2.13, all Scala test passed: https://github.com/LuciferYang/spark/runs/15278359785 Closes #42119 from LuciferYang/scala-xml-220. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Sean Owen <srowen@gmail.com>
### What changes were proposed in this pull request? This pr aims to upgrade `scala-xml` from 2.1.0 to 2.2.0. ### Why are the changes needed? The new version bring some bug fix like: - scala/scala-xml#651 - scala/scala-xml#677 The full release notes as follows: - https://github.com/scala/scala-xml/releases/tag/v2.2.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Actions - Checked Scala 2.13, all Scala test passed: https://github.com/LuciferYang/spark/runs/15278359785 Closes apache#42119 from LuciferYang/scala-xml-220. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Sean Owen <srowen@gmail.com>
No description provided.