-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not ignore XML comments when parsing #549
Conversation
@SethTisue done; you were right, additional excludes were needed (and added). Now I am getting ScalaJS compatibility issues which:
|
Yes, there's a compatibility problem we've introduced after merging #548 that breaks the Scala.js build for everyone. Standby. |
I've opened #551 for the compatibility issue. |
Ok, the build should be green, now. Sorry for the delay. Please check and see if your changes work on the latest commits to main. Thank you. |
fixes #508 - set `org.xml.sax.ext.LexicalHandler` on the `SAXParser` that `XMLLoader` uses; - override `LexicalHandler.comment()` in `FactoryAdapter` so that comments are added to the element content; - add unit tests; - add excludes for the binary compatibility checks.
One check (SCALA=3.0.1 SCALAJS_VERSION=1.7.0 ADOPTOPENJDK=8) fails with:
I have no clue why... |
That build error can probably be ignored. Seems like an issue with Travis or sbt-launcher. Googling around it might be a cache issue. |
fixes #508
org.xml.sax.ext.LexicalHandler
on theSAXParser
thatXMLLoader
uses;LexicalHandler.comment()
inFactoryAdapter
so that comments are added to the element content;