Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore XML comments when parsing #549

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Do not ignore XML comments when parsing #549

merged 1 commit into from
Sep 1, 2021

Commits on Aug 31, 2021

  1. Do not ignore XML comments when parsing: 

    fixes #508

- set `org.xml.sax.ext.LexicalHandler` on the `SAXParser` that `XMLLoader` uses;
- override `LexicalHandler.comment()` in `FactoryAdapter` so that comments are added to the element content;
- add unit tests;
- add excludes for the binary compatibility checks.
    @dubinsky
    dubinsky committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    f92ae49 View commit details
    Browse the repository at this point in the history