Add OSGi headers and source bundle #3
Conversation
Fixed scala#1.
|
/cc @jsuereth. |
There was a problem hiding this comment.
Is this build pushing the source bundle too? I'm a bit unfamiliar with what this does in non-eclipse OSGi environs....
There was a problem hiding this comment.
Oh, nevermind, just saw the packageSrc. Sweet.
|
LGTM. I may be copying this for OSGi-ifying sbt jars :) |
|
👍 |
|
Could we get this in, please? /cc @gkossakowski |
|
@adriaanm: I don't have access rights to merge PRs here. Is there a way to configure access right across the entire scala organization for me? |
|
fixed for all recently created repos -- sorry about that! |
There was a problem hiding this comment.
Note that this must be coordinated with https://github.com/scala/scala/blob/master/versions.properties, https://github.com/scala/scala-partest/blob/master/build.sbt#L19, and possibly others (TODO for me: make an overview of this)
There was a problem hiding this comment.
This should not be checked in with a non-SNAPSHOT version, the release process is the only place where it should tick over to a real version, ever so briefly.
There was a problem hiding this comment.
Reason: if I checkout this locally and publish-local, I will overwrite the local binaries with something newer than the released version. Those might be resolved by an upstream project inducing the subtle brand of calamity that we can do without.
There was a problem hiding this comment.
I agree, but I didn't want to push this change in this PR, which is about OSGi. If everyone agrees on -SNAPSHOT I can prepare another PR.
There was a problem hiding this comment.
@adriaanm What should I do about those files? Wouldn't they evolve naturally, once a new release of scala-xml is cut? (assuming the propagation step is done on releases).
There was a problem hiding this comment.
Sorry, I again forgot about using snapshot in the repo . +1 on what Jason said.
There was a problem hiding this comment.
Also, that change is fine in this pr, as long as it's a separate commit
|
Merging -- I'll follow up with changing to snapshot version. |
Add OSGi headers and source bundle
|
Thanks @adriaanm, I got delayed with other OSGi goodness on our side. |
5 participants
A few changes needed for proper Eclipse consumption as OSGi:
Fixed #1.