Skip to content

2.13: new Scala SHA (and add Finch) #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 18, 2021
Merged

2.13: new Scala SHA (and add Finch) #1519

merged 8 commits into from
Dec 18, 2021

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Dec 15, 2021 •
edited
Loading

@SethTisue SethTisue self-assigned this Dec 15, 2021
@SethTisue SethTisue mentioned this pull request Dec 15, 2021
Closed
@SethTisue
Copy link
Member Author

cats and twitter-util are failing?!

@lrytz
Copy link
Member

lrytz commented Dec 16, 2021

OOME in both 🤔

@SethTisue
Copy link
Member Author

cats failure is reproducible outside of dbuild with ++2.13.8-bin-b59fa66 and testsJVM/testOnly *NonEmptyListSuite

but you have to publishLocal kind-projector 0.13.2 and semanticdb-scalac 4.4.30 for 2.13.8-bin-b59fa66 first (cp -rp semanticdb/scalac/library/src/main/scala-2.13.7 semanticdb/scalac/library/src/main/scala-2.13.8, semanticdbScalacPlugin/publishLocal, semanticdbScalacCore/publishLocal)

==> X cats.tests.NonEmptyListSuite.grouped is consistent with iterator.toList.grouped  8.578s munit.FailException: Failing seed: zagPzwaJu-99K9DrqnArRx9CQPJ9lpLoh2EIUF8F5qI=
You can reproduce this failure by adding the following override to your suite:

  override val scalaCheckInitialSeed = "zagPzwaJu-99K9DrqnArRx9CQPJ9lpLoh2EIUF8F5qI="

Exception raised on property evaluation.
> ARG_0: NonEmptyList(1188467134)
> ARG_1: 474128334
> ARG_1_ORIGINAL: 1896513336
> Exception: java.lang.OutOfMemoryError: Java heap space
    at munit.ScalaCheckSuite.propToTry(ScalaCheckSuite.scala:98)
Caused by: java.lang.OutOfMemoryError: Java heap space

note the .grouped, which suggests scala/scala#9818 as a likely cause

@SethTisue
Copy link
Member Author

twitter-util failure is reproducible outside dbuild with ++2.13.8-bin-b59fa66 and util-core/testOnly com.twitter.concurrent.AsyncStreamTest

[info] - Cons: grouped() works like Seq.grouped *** FAILED ***
[info]   OutOfMemoryError was thrown during property evaluation.
[info]     Message: Java heap space
[info]     Occurred when passed generated values (
[info]       arg0 = List(),
[info]       arg1 = 536870911 // 2 shrinks
[info]     )

again, grouped, so I think we just need to revert that PR

SethTisue added a commit to SethTisue/scala that referenced this pull request Dec 16, 2021
@SethTisue
Revert "GroupedIterator improvements"
e0228a1 
This reverts commit d047407.

Reverts PR scala#9818; see scala/community-build#1519 for details
on the community build failures
This was referenced Dec 16, 2021
Merged
Merged
@SethTisue
Copy link
Member Author

SethTisue commented Dec 17, 2021 •
edited
Loading

waiting for Travis-CI to publish a nightly for scala/scala#9859, then we can try again

new runs queued

@SethTisue SethTisue changed the title 2.13: new Scala SHA 2.13: new Scala SHA (and add Finch) Dec 17, 2021
@SethTisue SethTisue merged commit f04b7bd into scala:2.13.x Dec 18, 2021
@SethTisue SethTisue deleted the new-scala-2.13-sha-20211215 branch December 18, 2021 05:08
@SethTisue SethTisue restored the new-scala-2.13-sha-20211215 branch December 18, 2021 05:08
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
@SethTisue
Revert "GroupedIterator improvements"
686caa9 
This reverts commit 0a4b697.

Reverts PR scala/scala#9818; see scala/community-build#1519 for details
on the community build failures
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
@SethTisue
Revert "GroupedIterator improvements"
5d3120d 
This reverts commit ed9356d.

Reverts PR scala/scala#9818; see scala/community-build#1519 for details
on the community build failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SethTisue SethTisue

Labels
contents: other contents: Scala SHA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @lrytz